Home Original page

[PATCH 0/4] bfd: Add support for Cygwin x86_64 core dumps

Jon Turney jon.turney@dronecode.org.uk
Sun Jul 12 12:57:07 GMT 2020 
On 09/07/2020 14:38, Nick Clifton via Binutils wrote:
> Hi Jon,
> 
>> Fixes and additions support x86_64 in reading the NT_WIN32PSTATUS ELF notes
>> in a Cygwin "core dump".
> 
> The patch series looks fine to me apart from one thing:
> 
>  From patch 2/4:
> 
>    -  if (note->descsz < 728)
>    -    return TRUE;
> 
> Without this check it will be possible for a corrupt core file
> to trigger invalid reads beyond the end of the note section.
> (Binary fuzzers love triggering this kind of bug).  So I think
> that everywhere you read data from a note you should make sure
> that there actually is data present first.

Yes, that should be done.  I posted a revised patch set with that added.
More information about the Binutils mailing list