Nick Clifton nickc@redhat.com
Tue Sep 8 08:48:51 GMT 2020

• Previous message (by thread): sync libiberty from gcc
• Next message (by thread): plugin handler patch
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Guys,

  I am checking in the patch below to handle the situation where the
  plugin handler is asked to canonicalize a weak symbol of an unknown
  type.  This situation actually occurred in real life due to a bug in
  the LTO plugin, and that bug was made worse by the code in the handler
  not detecting it and leaving the section pointer set to NULL.

Cheers
  Nick

bfd/ChangeLog
2020-09-08  Nick Clifton  <nickc@redhat.com>

	* plugin.c (bfd_plugin_canonicalize_symtab): Handle the case of an
	unrecognized symbol type in a weak definition.

diff --git a/bfd/plugin.c b/bfd/plugin.c
index 593e277747..bed98520da 100644
--- a/bfd/plugin.c
+++ b/bfd/plugin.c
@@ -640,6 +640,8 @@ bfd_plugin_canonicalize_symtab (bfd *abfd,
 	  if (current_plugin->has_symbol_type)
 	    switch (syms[i].symbol_type)
 	      {
+	      default:
+		/* FIXME: Should we issue an error here ?  */
 	      case LDST_UNKNOWN:
 		/* What is the best fake section for LDST_UNKNOWN?  */
 	      case LDST_FUNCTION:

---

• Previous message (by thread): sync libiberty from gcc
• Next message (by thread): plugin handler patch
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list