Alan Modra amodra@gmail.com
Tue Aug 24 11:57:11 GMT 2021

• Previous message (by thread): [PATCH 5/7][LoongArch] Gas support
• Next message (by thread): [PATCH 6/7][LoongArch]LD support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Sat, Aug 14, 2021 at 04:18:08PM +0800, Paul Hua via Binutils wrote:
> +++ b/gas/config/loongarch-parse.y
> +int
> +loongarch_parse_expr (const char *expr,
> +		      struct reloc_info *reloc_stack_top,
> +		      size_t max_reloc_num,
> +		      size_t *reloc_num,
> +		      offsetT *imm);
> +
> +int
> +loongarch_parse_expr (const char *expr,
> +		      struct reloc_info *reloc_stack_top,
> +		      size_t max_reloc_num,
> +		      size_t *reloc_num,
> +		      offsetT *imm)
> +{
> +  int ret;

> +++ b/gas/config/tc-loongarch.c
> +extern int loongarch_parse_expr (const char *expr,
> +				 struct reloc_info *reloc_stack_top,
> +				 size_t max_reloc_num, size_t *reloc_num,
> +				 offsetT *imm_if_no_reloc);
> +

Don't do this.  Put the declaration in a header and include in both
files.  Otherwise would be OK if there was a proper testsuite.  That
needs to be written before this can be accepted.

-- 
Alan Modra
Australia Development Lab, IBM

---

• Previous message (by thread): [PATCH 5/7][LoongArch] Gas support
• Next message (by thread): [PATCH 6/7][LoongArch]LD support
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list