Jim Wilson jimw@sifive.com
Wed Feb 10 21:00:34 GMT 2021

• Previous message (by thread): [PATCHv2 6/9] bfd/binutils: add support for RISC-V CSRs in core files
• Next message (by thread): PING: Re: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Mon, Feb 1, 2021 at 4:00 AM Andrew Burgess <andrew.burgess@embecosm.com>
wrote:

>     bfd/ChangeLog:
>
>             * elf-bfd.h (elfcore_write_riscv_csr): Declare.
>             * elf.c (elfcore_grok_riscv_csr): New function.
>             (elfcore_grok_note): Handle NT_RISCV_CSR.
>             (elfcore_write_riscv_csr): New function.
>             (elfcore_write_register_note): Handle '.reg-riscv-csr'.
>
>     binutils/ChangeLog:
>
>             * readelf.c (get_note_type): Handle NT_RISCV_CSR.
>
>     include/ChangeLog:
>
>             * elf/common.h (NT_RISCV_CSR): Define.
>
> Looks OK to me.

As before, ideally new functions should have explanatory comments before
them, unless maybe that rule has changed.

Jim

---

• Previous message (by thread): [PATCHv2 6/9] bfd/binutils: add support for RISC-V CSRs in core files
• Next message (by thread): PING: Re: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list