CHIGOT, CLEMENT clement.chigot@atos.net
Mon Nov 15 10:18:10 GMT 2021

• Previous message (by thread): [PATCH] PR 28447: implement multiple parameters for .file on XCOFF
• Next message (by thread): [PATCH] PR 28447: implement multiple parameters for .file on XCOFF
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Alan,

It should be good with this patch now.
I've added some protections over my newly made code. It should protect other targets
not supporting the x_ftype field.

I didn't add the protection for the normalize symtab part. Because, PE is already
avoided here. But also because it doesn't make sense to me to avoid normalizing
the aux entry's string because it's representing a filename entry (which is obviously
a string). However, it might be safer to add it anyway as we have no idea about
what can be stored if the target doesn't support x_ftype field.
Does it look good to you or should I add the protection here too ?
(here: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=bfd/coffgen.c;h=40f1ac718e48c74f1a95576a6ed9aa2c8a79f2af;hb=HEAD#l1950)

Thanks,
Clément
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bfd-avoid-modifications-over-C_FILE-filename-aux-ent.patch
Type: text/x-patch
Size: 2354 bytes
Desc: 0001-bfd-avoid-modifications-over-C_FILE-filename-aux-ent.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20211115/52ff103f/attachment.bin>

---

• Previous message (by thread): [PATCH] PR 28447: implement multiple parameters for .file on XCOFF
• Next message (by thread): [PATCH] PR 28447: implement multiple parameters for .file on XCOFF
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list