[PATCH 2/5] Skip ELF-specific tests when targeting pe-aarch64
Jan Beulich
jbeulich@suse.com
Thu Dec 22 07:38:06 GMT 2022
More information about the Binutils mailing list
Thu Dec 22 07:38:06 GMT 2022
- Previous message (by thread): [PATCH 2/5] Skip ELF-specific tests when targeting pe-aarch64
- Next message (by thread): [PATCH 3/5] Add pe-aarch64 relocations
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 21.12.2022 21:19, Mark Harmstone wrote: > On 16/12/22 07:07, Jan Beulich wrote: >> On 16.12.2022 03:13, Mark Harmstone wrote: >>> There's currently an awful lot of test failures for pe-aarch64, because >>> of tests that assume that aarch64 implies ELF. This sets notarget for >>> these. >> Hmm, not very nice, but perhaps okay as a first step. However, ... >> >>> --- >>> binutils/testsuite/binutils-all/objcopy.exp | 1 + >>> gas/testsuite/gas/aarch64/adr_1.d | 1 + >>> gas/testsuite/gas/aarch64/advsimd-mov-bad.d | 1 + >>> gas/testsuite/gas/aarch64/b_1.d | 1 + >>> gas/testsuite/gas/aarch64/beq_1.d | 1 + >>> gas/testsuite/gas/aarch64/bfloat16-directive-be.d | 1 + >>> gas/testsuite/gas/aarch64/bfloat16-directive-le.d | 1 + >>> gas/testsuite/gas/aarch64/codealign.d | 2 +- >>> gas/testsuite/gas/aarch64/codealign_1.d | 1 + >>> gas/testsuite/gas/aarch64/dwarf.d | 1 + >>> gas/testsuite/gas/aarch64/ilp32-basic.d | 1 + >>> gas/testsuite/gas/aarch64/int-insns.d | 1 + >>> gas/testsuite/gas/aarch64/ldr_1.d | 1 + >>> gas/testsuite/gas/aarch64/litpool.d | 2 +- >>> gas/testsuite/gas/aarch64/mapmisc.d | 2 +- >>> gas/testsuite/gas/aarch64/mapping.d | 2 +- >>> gas/testsuite/gas/aarch64/mapping2.d | 2 +- >>> gas/testsuite/gas/aarch64/mapping3.d | 2 +- >>> gas/testsuite/gas/aarch64/mapping4.d | 2 +- >>> gas/testsuite/gas/aarch64/mapping_5.d | 1 + >>> gas/testsuite/gas/aarch64/mapping_6.d | 1 + >>> gas/testsuite/gas/aarch64/mops_invalid_2.d | 1 + >>> gas/testsuite/gas/aarch64/movw_label.d | 1 + >>> gas/testsuite/gas/aarch64/optional.d | 1 + >>> gas/testsuite/gas/aarch64/pac_ab_key.d | 1 + >>> gas/testsuite/gas/aarch64/pac_negate_ra_state.d | 1 + >>> gas/testsuite/gas/aarch64/pr20364.d | 1 + >>> gas/testsuite/gas/aarch64/pr27217.d | 1 + >>> gas/testsuite/gas/aarch64/pr29519.d | 1 + >>> gas/testsuite/gas/aarch64/programmer-friendly.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-data.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g0-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g0.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g0_nc-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g1-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g1_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_g2.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_hi12-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_hi12.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-ilp32-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-ldst16.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-ldst32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-ldst64.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12-ldst8.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst16.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst64.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst8.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-dtprel_lo12_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-gotoff_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-gotoff_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-gottprel_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-gottprel_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-insn.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g0.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g1_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g2.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g2_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-prel_g3.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsdesc_off_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsdesc_off_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsgd_g0_nc.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsgd_g1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm-ilp32-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm-page-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm-page-ilp32-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst16-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst16.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst32-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst64-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst64.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst8-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12-ldst8.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst16-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst16.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst32-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst64-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst64.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst8-ilp32.d | 1 + >>> gas/testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst8.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_1.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_10.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_11.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_12.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_13.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_14.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_15.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_16.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_17.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_18.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_19.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_2.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_20.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_21.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_22.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_23.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_24.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_25.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_26.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_27.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_28.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_3.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_4.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_5.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_6.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_7.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_8.d | 1 + >>> gas/testsuite/gas/aarch64/sve-movprfx_9.d | 1 + >>> gas/testsuite/gas/aarch64/symbol-variant_pcs-1.d | 1 + >>> gas/testsuite/gas/aarch64/symbol-variant_pcs-2.d | 1 + >>> gas/testsuite/gas/aarch64/symbol-variant_pcs-3.d | 1 + >>> gas/testsuite/gas/aarch64/system.d | 1 + >>> gas/testsuite/gas/aarch64/tail_padding.d | 1 + >>> gas/testsuite/gas/aarch64/tbz_1.d | 1 + >>> gas/testsuite/gas/aarch64/tls-desc.d | 1 + >>> gas/testsuite/gas/aarch64/tls.d | 1 + >>> gas/testsuite/gas/pe/big-obj.d | 1 + >> ... this clearly isn't an ELF test and hence can't fall into here. >> At least for PE tests I think it would be better if they really worked. >> If anything this should be xfail-ed imo (in a separate patch with a >> suitable description). > > Thanks Jan. This patch isn't essential, so I'll save it for a later date if it's contentious. The other four are the important ones. FTAOD my comment was merely about pe/big-obj.d. So perhaps you want to split that off and get the rest of this change in? Jan
- Previous message (by thread): [PATCH 2/5] Skip ELF-specific tests when targeting pe-aarch64
- Next message (by thread): [PATCH 3/5] Add pe-aarch64 relocations
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Binutils mailing list