Home Original page

[PATCH] windres: add quotes around preprocessor cmd if needed

Jan Beulich jbeulich@suse.com
Tue Jun 28 10:16:49 GMT 2022 
On 28.06.2022 11:37, Clément Chigot wrote:
> On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 28.06.2022 09:35, Clément Chigot via Binutils wrote:
>>> This patch ensures that the gcc binary called by windres is quoted if
>>> needed. Otherwise, errors can occur if the gcc is under a folder having
>>> a name containing a space (eg "Program Files").
>>>
>>> binutils/
>>>         * resrc.c (DEFAULT_PREPROCESSOR): Split into...
>>>         (DEFAULT_PREPROCESSOR_CMD): that...
>>>         (DEFAULT_PREPROCESSOR_ARGS): and that.
>>>         (look_for_default): Add quotes around the command if needed.
>>>         (read_rc_file): Adapt to new defines.
>>
>> Commenting is a little difficult without you providing the patch (also)
>> inline:
> 
> IIRC, it should be done directly but the "é" in my name makes the
> mailservers think my patches are binaries...

I don't think that's what is the issue. There may be mail clients which
display text attachments, but then it's still an attachment, and other
clients may only ever handle attachments as such (mine, for example,
might display such an attachment, but would not consider it part of the
reply context when first setting up a reply mail, yet having it there
is what is the primary goal when talking about commenting on patches).
If you can't configure your client such that inlined patches make it
through ungarbled, it would still be helpful if you could _also_ inline
the patch, indicating that it may not be well-formed and hence for
applying the attached variant should be used.

Jan
More information about the Binutils mailing list