Home Original page

[PATCH v2 0/6] RISC-V: Fix disassembler types and styles

Jeff Law jeffreyalaw@gmail.com
Wed Oct 5 21:52:31 GMT 2022 
On 10/3/22 11:40, Palmer Dabbelt wrote:
> On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote:
>> Tsukasa OI via Binutils <binutils@sourceware.org> writes:
>>
>>> Hello,
>>>
>>> This patchset fixes various typing and styling errors on the RISC-V
>>> disassembler.
>>
>> I can't approve binutils patches.
>>
>> I've taken a look through this series, and other than the minor typo I
>> spotted, this all looks good to me.
>
> My worry with these things is that it's sort of a grey area in terms 
> of what our stable user interface is: there's definitely folks who try 
> and parse the text output of tools like objdump and changing anything 
> risks breaking that.  IMO that's too strict of a stable interface to 
> keep around as it pretty much prevents us from fixing any disassembly 
> weirdness, but I'm not sure if that's what other ports do and I don't 
> want to make a mess by breaking users' expectations here.
>
> That said, as far as I can tell the only user-visible change here is 
> to print some bits with the correct syntax coloring in GDB. Seems 
> pretty straight-forward to say anything users can't rely on parsing 
> syntax highlighting colors being a stable interface, so maybe we can 
> just punt on the grey area for now ;)

I don't think the precise for of disassembly output needs to stay 
stable; it's certainly not something we've ever promised or encouraged 
folks to rely on.  Obviously we shouldn't change it just for the sake of 
changing it, but if we need to make a fix, we should just make it.


jeff
More information about the Binutils mailing list