Home Original page

[PATCH v3 1/1] bfd, binutils, gas: Remove/mark unused variables

Jan Beulich jbeulich@suse.com
Wed Sep 21 06:15:21 GMT 2022 
On 21.09.2022 07:54, Tsukasa OI wrote:
> On 2022/09/20 21:50, Nick Clifton wrote:
>> Hi Tsukasa,
>>
>>> bfd/ChangeLog:
>>>
>>>     * elf32-lm32.c (lm32_elf_size_dynamic_sections): Mark unused
>>>     rgot_count variable.
>>>     * elf32-nds32.c (elf32_nds32_unify_relax_group): Remove unused
>>>     count variable.
>>>     * mmo.c (mmo_scan): Mark unused lineno variable.
>>>
>>> binutils/ChangeLog:
>>>
>>>     * windmc.c (write_rc): Remove unused i variable.
>>>
>>> gas/ChangeLog:
>>>
>>>     * config/tc-riscv.c (riscv_ip): Remove unused argnum variable.
>>>
>>> ld/ChangeLog:
>>>
>>>     * pe-dll.c (generate_reloc): Remove unused bi and page_count
>>>     variables.
>>
>> Patch approved - please apply.
>>
>> Cheers
>>   Nick
>>
> 
> Nick and Jan,
> 
> I sincerely apologize that I thought previous "okay" mail from Jan, a
> maintainer:
> <https://sourceware.org/pipermail/binutils/2022-September/122890.html>
> as an "approval" and applied this patch already.

No, you were right in doing so and - Nick, please correct me if
I'm wrong - I might guess that Nick simply overlooked that I did
give an okay already.

> I will not merge the patch again unless the word "approve" is used
> explicitly.  I am really sorry.

Hence also no need for this.

Jan
More information about the Binutils mailing list