Tom Tromey tom@tromey.com
Fri Feb 17 19:29:04 GMT 2023

• Previous message (by thread): [PATCH 2/4] Don't use chew comments for static functions
• Next message (by thread): [PATCH 4/4] Redefine FUNCTION in doc.str
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

The opening and closing node in BFD starts:

    File: bfd.info, [...]

	 /* Set to N to open the next N BFDs using an alternate id space.  */
	 extern unsigned int bfd_use_reserved_id;

    2.13 Opening and closing BFDs
    =============================

That is, there's a stray C comment and declaration before any other
text or subsections.

This occurs because the code fragment for bfd_use_reserved_id comes
before the SECTION comment.  Hoisting it makes this a little nicer.

bfd/ChangeLog
2023-02-17  Tom Tromey  <tom@tromey.com>

	* opncls.c: Hoist the SECTION comment.
---
 bfd/ChangeLog |  4 ++++
 bfd/opncls.c  | 16 ++++++++--------
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/bfd/opncls.c b/bfd/opncls.c
index 95906526973..15ee4f7f44e 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -37,6 +37,14 @@
 #define S_IXOTH 0001	/* Execute by others.  */
 #endif
 
+/*
+SECTION
+	Opening and closing BFDs
+
+SUBSECTION
+	Functions for opening and closing
+*/
+
 /* Counters used to initialize the bfd identifier.  */
 
 static unsigned int bfd_id_counter = 0;
@@ -179,14 +187,6 @@ _bfd_free_cached_info (bfd *abfd)
   return true;
 }
 
-/*
-SECTION
-	Opening and closing BFDs
-
-SUBSECTION
-	Functions for opening and closing
-*/
-
 /*
 FUNCTION
 	bfd_fopen
-- 
2.39.1

---

• Previous message (by thread): [PATCH 2/4] Don't use chew comments for static functions
• Next message (by thread): [PATCH 4/4] Redefine FUNCTION in doc.str
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list