Mike Frysinger vapier@gentoo.org
Fri Oct 13 11:35:55 GMT 2023

• Previous message (by thread): [PATCH 3/5] LoongArch: Multiple relax_trip in one relax_pass
• Next message (by thread): [PATCH] sim: or1k: Eliminate dangerous RWX load segments
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On 19 Aug 2023 08:45, Stafford Horne wrote:
> This fixes test failures caused by the new linker warning which report:
> 
>   ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissions
> 
> Fix this by splitting the linker MEMORY into ram and rom to avoid
> generating RWX sections.  This required tests to be adjusted to fix
> issues with the move.  Namely:
> 
>   - fpu tests: were incorrectly using l.ori with ha(anchor) which now
>     that we pushed the anchor up in memory it exposes the bug.  Update
>     to used the correct l.movhi instruction instead.
>   - adrp test: the test reports ram offset addresses, now that we have
>     moved memory layout around a bit I adjusted the test output.  Some
>     padding is added before pi to show that the actual address of pi and
>     the adrp page offset are not the same.
> 
> Bug: https://sourceware.org/PR29957

nit: put [PR sim/29957] at the end of the git commit summary (first line)

otherwise, lgtm, thanks
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20231013/25bc4079/attachment.sig>

---

• Previous message (by thread): [PATCH 3/5] LoongArch: Multiple relax_trip in one relax_pass
• Next message (by thread): [PATCH] sim: or1k: Eliminate dangerous RWX load segments
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list