Nick Clifton nickc@redhat.com
Wed Sep 27 13:38:25 GMT 2023

• Previous message (by thread): [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
• Next message (by thread): [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Frederic,

   Approved - please apply - but with one very small change:

>   #define PT_OPENBSD_WXNEEDED  (PT_LOOS + 0x5a3dbe7)  /* Program does W^X violations.  */
> +#define PT_OPENBSD_NOBTCFI   (PT_LOOS + 0x5a3dbe8)  /* no branch target CFI.  */
>   #define PT_OPENBSD_BOOTDATA  (PT_LOOS + 0x5a41be6)  /* Section for boot arguments.  */

Please could you use a capital letter at the start of the comment.  ie:

 > +#define PT_OPENBSD_NOBTCFI   (PT_LOOS + 0x5a3dbe8)  /* No branch target CFI.  */

Cheers
   Nick

---

• Previous message (by thread): [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
• Next message (by thread): [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list