Home Original page

[PATCH v2] GAS/MIPS: Fix testcase module-defer-warn2 for r2+ triples

YunQiang Su wzssyqa@gmail.com
Fri Sep 29 13:41:29 GMT 2023 
Maciej W. Rozycki <macro@orcam.me.uk> 于2023年9月29日周五 07:46写道：
>
> On Tue, 26 Sep 2023, YunQiang Su wrote:
>
> > Let's convert this testcase to `.d' format,  and split it to
> >    module-defer-warn2-r2
> >    module-defer-warn2-prer2,
> > and use `skip/target` tags to select the right triples.
>
>  As I told you with v1:
>
> >  It seems to me that the best course of action will be converting the test
> > to the .d format first, which gives more control, and then split it into
> > two, using #skip/#noskip tags as appropriate to select the right one for
> > the respective targets.
>
> -- so it has to be a series of two patches:
>
> * 1/2 to convert the test case to the .d format (keeping the semantics
>   the same),
>
> * 2/2 to split it into two, using #skip/#noskip tags.
>

I will do so.

> NB why did you use #target rather than #noskip?
>

Sorry. I misunderstand the meaning of "#noskip".

>  Also please start a new thread when submitting updated patches rather
> than replying to an old one.
>

I will do so.

>   Maciej



-- 
YunQiang Su
More information about the Binutils mailing list