Home Original page

[PATCH v2] GAS/MIPS: Fix testcase module-defer-warn2 for r2+ triples

YunQiang Su yunqiang.su@cipunited.com
Fri Sep 29 14:23:15 GMT 2023 
在 2023/9/29 22:18, Maciej W. Rozycki 写道:
> On Fri, 29 Sep 2023, YunQiang Su wrote:
>
>>>   As I told you with v1:
>>>
>>>>   It seems to me that the best course of action will be converting the test
>>>> to the .d format first, which gives more control, and then split it into
>>>> two, using #skip/#noskip tags as appropriate to select the right one for
>>>> the respective targets.
>>> -- so it has to be a series of two patches:
>>>
>>> * 1/2 to convert the test case to the .d format (keeping the semantics
>>>    the same),
>>>
>>> * 2/2 to split it into two, using #skip/#noskip tags.
>>>
>> I will do so.
>   As always one self-contained change per patch please.  Switching to the
> .d format is one change and fixing R2+ support is another.  So it has to
> be two separate changes.


To be make thing more clear, and I am worrying that, the patch can be 
spilt to 3 even:

1. switch to .d format

2. add "#skip" tag

3. add new r2 tests.


So, if we'd like to split to 2 patches, should they are {{1,2}, 3} or 
{1, {2, 3}}, or should we

split it to 3 ones?


>    Maciej
More information about the Binutils mailing list