Home Original page

[PATCH v2 2/9] aarch64: Align SFrame terminology in comments to specs and x86

Jens Remus jremus@linux.ibm.com
Fri Feb 23 17:07:53 GMT 2024 
Use the term "frame pointer" (FP) instead of "base pointer". This aligns
with the terminology used in the SFrame specification. Additionally it
helps not to confuse "base-pointer register" with the term "BASE_REG"
used in the specification to denote either the SP or FP register.

While at it align the frame-pointer and return address register comments
to the x86 AMD64 ones.

gas/
	* config/tc-aarch64.h: Align SFrame terminology in comments to
	  specs and x86 AMD64.

Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---

Notes (jremus):
    This patch can be dropped, if subsequent patch "sframe: Enhance comments
    for SFRAME_CFA_*_REG macros" gets accepted.

 gas/config/tc-aarch64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h
index 1b8badad9fdc..599d78db7908 100644
--- a/gas/config/tc-aarch64.h
+++ b/gas/config/tc-aarch64.h
@@ -271,11 +271,11 @@ extern bool aarch64_support_sframe_p (void);
 extern unsigned int aarch64_sframe_cfa_sp_reg;
 #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg
 
-/* The base-pointer register number for CFA stack trace info.  */
+/* The frame-pointer register number for SFrame stack trace info.  */
 extern unsigned int aarch64_sframe_cfa_fp_reg;
 #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg
 
-/* The return address register number for CFA stack trace info.  */
+/* The return address register number for SFrame stack trace info.  */
 extern unsigned int aarch64_sframe_cfa_ra_reg;
 #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg
 
-- 
2.40.1
More information about the Binutils mailing list