Jan Beulich jbeulich@suse.com
Mon Feb 26 13:01:08 GMT 2024

• Previous message (by thread): [PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable
• Next message (by thread): [PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On 24.02.2024 08:38, Indu Bhagat wrote:
> On 2/23/24 09:07, Jens Remus wrote:
>> gas/
>> 	* config/tc-i386.c: Remove unused SFrame CFI RA register
>> 	  variable.
>>
> 
> The ChangeLog formatting is a bit off here and in the rest of the 
> patches in this series.
> 
> The indentation of each line should be such that all content lines up 
> below the *, like so:
> 
> <TAB>* xyz.c: first line content
> <TAB>next line content
> 
> Other than that, LGTM.

Just to clarify: It's not actually a missing SFRAME_CFA_RA_REG define
(and initialization of the variable)?

Jan

---

• Previous message (by thread): [PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable
• Next message (by thread): [PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list