Home Original page

[PATCH 1/2] Rename Opcode Space Name Vexmap7 to Map7

Jan Beulich jbeulich@suse.com
Fri Nov 8 10:36:27 GMT 2024 
On 06.11.2024 09:58, Hu, Lin1 wrote:
> --- a/opcodes/i386-opc.h
> +++ b/opcodes/i386-opc.h
> @@ -995,7 +995,7 @@ typedef struct insn_template
>       4: EVEXMAP4 opcode prefix / space.
>       5: EVEXMAP5 opcode prefix / space.
>       6: EVEXMAP6 opcode prefix / space.
> -     7: VEXMAP7 opcode prefix / space.
> +     7: MAP7 opcode prefix / space.
>       8: XOP 08 opcode space.
>       9: XOP 09 opcode space.
>       A: XOP 0A opcode space.
> @@ -1007,7 +1007,7 @@ typedef struct insn_template
>  #define SPACE_EVEXMAP4	4
>  #define SPACE_EVEXMAP5	5
>  #define SPACE_EVEXMAP6	6
> -#define SPACE_VEXMAP7	7
> +#define SPACE_MAP7	7

Maybe best seen here: maps 4, 5, and 6 denote EVEX in their identifiers.
Having it be just "MAP7" suggests it's also usable with legacy encodings.
If you really think "VEX" in the name ends up misleading, then may I
suggest to use e.g. "xVEX" instead?

> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
> @@ -112,6 +112,7 @@
>  #define Space0F    OpcodeSpace=SPACE_0F
>  #define Space0F38  OpcodeSpace=SPACE_0F38
>  #define Space0F3A  OpcodeSpace=SPACE_0F3A
> +#define SpaceMap7  OpcodeSpace=SPACE_MAP7
>  #define SpaceXOP08 OpcodeSpace=SPACE_XOP08
>  #define SpaceXOP09 OpcodeSpace=SPACE_XOP09
>  #define SpaceXOP0A OpcodeSpace=SPACE_XOP0A

Like above, this placement again suggests that it might cover legacy
encodings? What's wrong with ...

> @@ -120,8 +121,6 @@
>  #define EVexMap5 OpcodeSpace=SPACE_EVEXMAP5
>  #define EVexMap6 OpcodeSpace=SPACE_EVEXMAP6
>  
> -#define VexMap7 OpcodeSpace=SPACE_VEXMAP7

... keeping it where it was (perhaps with the blank line removed)?

Pre-approved with both adjustments made. Unless of course you disagree,
in which case we need to discuss things further.

Jan
More information about the Binutils mailing list