Home Original page

[PATCH v1] x86: Support ZHAOXIN GMI instructions

Jan Beulich jbeulich@suse.com
Mon Oct 14 06:54:02 GMT 2024 
On 14.10.2024 04:03, mayshao-oc wrote:
>         This patch adds support for Zhaoxin GMI instructions.
>         The documentation is attached for your reference.
>         Test ok, ok for trunk?

In the NEWS entry, please add "x86" one way or another. Not everyone may
know that Zhaoxin is an x86 flavor. Also the entry needs to move up, into
the post-2.43 section.

For the i386-gen change I wonder whether GMI is an entirely separate
extension, or kind of an extension to PadLock. Can you clarify the
relationship please?

In i386-dis.c, if - following earlier comments - you still need some fixup
function(s), please name them suitably. The pre-existing OP_0f07() is
grossly misnamed, and that misnaming shouldn't be further extended.

Jan
More information about the Binutils mailing list