Home Original page

[PATCH v2] bfd: Add minimal support to handle note that describes xsave layout

Balasubrmanian, Vignesh Vignesh.Balasubrmanian@amd.com
Mon Dec 8 10:27:35 GMT 2025 
[AMD Official Use Only - AMD Internal Distribution Only]

There are similar functions in "bfd/elf.c" like "elfcore_grok_loongarch_cpucfg" has bigger length.
If it is not intended, I will wrap this one.

Does the ready-to-apply version mean I should add a "Reviewed-by" line?


thanks,
Vigneshbalu.

-----Original Message-----
From: Jan Beulich <jbeulich@suse.com>
Sent: Monday, December 8, 2025 1:36 PM
To: Balasubrmanian, Vignesh <Vignesh.Balasubrmanian@amd.com>
Cc: binutils@sourceware.org; George, Jini Susan <JiniSusan.George@amd.com>; christina.schimpe@intel.com; Sharma, Alok Kumar <AlokKumar.Sharma@amd.com>; jhb@FreeBSD.org; simark@simark.ca
Subject: Re: [PATCH v2] bfd: Add minimal support to handle note that describes xsave layout

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On 08.12.2025 08:57, Balasubrmanian, Vignesh wrote:
> Below are a couple of changes made in V2.
>
> Added macro for ".reg-xsave-layout" and used dashes instead of dots.
> Modified subject line according to the code in the patch.

Two cosmetic things:

The long line in elfcore_grok_xsave_layout_desc() will need wrapping.

Kind of the opposite, in elfcore_write_xsave_layout() the function invocation could be un-wrapped some, making better use of line length.

Okay with at least the former aspect taken care of. (If you need this committed on your behalf, please re-submit a ready-to-apply version.)

Jan
More information about the Binutils mailing list