Home Original page

[PATCH] gas/CFI: fix .cfi_escape parsing when equates are in use

Jan Beulich jbeulich@suse.com
Mon Dec 22 10:22:32 GMT 2025 
On 20.12.2025 06:11, Indu wrote:
> On 2025-12-18 7:07 a.m., Jan Beulich wrote:
>> @@ -1010,7 +1009,7 @@ dot_cfi_escape (int ignored ATTRIBUTE_UN
>>   	}
>>         else
>>   	{
>> -	  /* We may still be at the opening parenthesis.  Leave it to expression()
>> +	  /* We may still be at an opening parenthesis.  Leave it to expression()
>>   	     to parse it and find the matching closing one.  */
>>   	  e->reloc = do_parse_cons_expression (&e->exp, e->type);
> 
> Unrelated to the current patch, I am wondering what is the expected 
> e->reloc for the case when e->type is CFI_ESC_sleb128 or CFI_ESC_uleb128.

None in the common case. Very few targets have suitable relocations, which
is reflected by there being very few BFD_RELOC_*LEB128*. This could likely
be generalized some, but it wouldn't buy us much here: The reloc type then
would merely be redundant with CFI_ESC_{s,u}leb128 in e->type.

Jan
More information about the Binutils mailing list