Home Original page

[V1 03/36] [SFrame-V3] libsframe: remove old sframe_decoder_get_funcdesc API

Indu Bhagat indu.bhagat@oracle.com
Mon Dec 29 09:28:36 GMT 2025 
sframe_decoder_get_funcdesc () was added for SFRAME_VERSION_1.  This has
since been obsoleted by introduction of SFRAME_VERSION_2 and its
corresponding sframe_decoder_get_funcdesc_v2 API.

Remove from the version script file as well.  We will bump the version
of the library to 3.0.0 in a subsequent patch (closer to release) and
consolidate the entries into a new LIBSFRAME_3.0 node.

Reviewed-by: Jens Remus <jremus@linux.ibm.com>

include/
	* sframe-api.h (sframe_decoder_get_funcdesc): Remove.
libsframe/
	* libsframe.ver: Likewise.
	* sframe.c (sframe_decoder_get_funcdesc): Remove definition.

---
[No Changes from RFC]
---
 include/sframe-api.h    | 11 -----------
 libsframe/libsframe.ver |  1 -
 libsframe/sframe.c      | 34 ----------------------------------
 3 files changed, 46 deletions(-)

diff --git a/include/sframe-api.h b/include/sframe-api.h
index fc46b855fa5..ec603a3f1d9 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -169,17 +169,6 @@ sframe_decoder_get_fre (sframe_decoder_ctx *ctx,
 			unsigned int fre_idx,
 			sframe_frame_row_entry *fre);
 
-/* Get the data (NUM_FRES, FUNC_START_ADDRESS) from the function
-   descriptor entry at index I'th in the decoder CTX.  If failed,
-   return error code.  */
-extern int
-sframe_decoder_get_funcdesc (sframe_decoder_ctx *ctx,
-			     unsigned int i,
-			     uint32_t *num_fres,
-			     uint32_t *func_size,
-			     int32_t *func_start_address,
-			     unsigned char *func_info);
-
 /* Get the data (NUM_FRES, FUNC_SIZE, FUNC_START_ADDRESS, FUNC_INFO,
    REP_BLOCK_SIZE) from the function descriptor entry at index I'th
    in the decoder CTX.  If failed, return error code.
diff --git a/libsframe/libsframe.ver b/libsframe/libsframe.ver
index 18ab92839e1..1204acec4bc 100644
--- a/libsframe/libsframe.ver
+++ b/libsframe/libsframe.ver
@@ -20,7 +20,6 @@ LIBSFRAME_2.0 {
     sframe_decoder_get_fixed_ra_offset;
     sframe_find_fre;
     sframe_decoder_get_num_fidx;
-    sframe_decoder_get_funcdesc;
     sframe_decoder_get_funcdesc_v2;
     sframe_decoder_get_fre;
     sframe_encode;
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index 289589043be..62c4e03e138 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -1438,40 +1438,6 @@ sframe_decoder_get_num_fidx (sframe_decoder_ctx *ctx)
   return num_fdes;
 }
 
-/* Get the data (NUM_FRES, FUNC_START_ADDRESS) from the function
-   descriptor entry at index I'th in the decoder CTX.  If failed,
-   return error code.  */
-/* FIXME - consolidate the args and return a
-   sframe_func_desc_index_elem rather?  */
-
-int
-sframe_decoder_get_funcdesc (sframe_decoder_ctx *ctx,
-			     unsigned int i,
-			     uint32_t *num_fres,
-			     uint32_t *func_size,
-			     int32_t *func_start_address,
-			     unsigned char *func_info)
-{
-  sframe_func_desc_entry_int *fdp;
-  int err = 0;
-
-  if (ctx == NULL || func_start_address == NULL || num_fres == NULL
-      || func_size == NULL)
-    return sframe_set_errno (&err, SFRAME_ERR_INVAL);
-
-  fdp = sframe_decoder_get_funcdesc_at_index (ctx, i);
-
-  if (fdp == NULL)
-    return sframe_set_errno (&err, SFRAME_ERR_FDE_NOTFOUND);
-
-  *num_fres = fdp->func_num_fres;
-  *func_start_address = fdp->func_start_pc_offset;
-  *func_size = fdp->func_size;
-  *func_info = fdp->func_info;
-
-  return 0;
-}
-
 int
 sframe_decoder_get_funcdesc_v2 (sframe_decoder_ctx *dctx,
 				unsigned int i,
-- 
2.43.0
More information about the Binutils mailing list