Home Original page

[PATCH v3 0/2] RISC-V: Fix abort when displaying data and add test

Nelson Chu nelson@rivosinc.com
Fri Feb 21 06:37:45 GMT 2025 
Thanks, I will wait for a few days and then commit if there are no
objections.

Nelson

On Thu, Feb 20, 2025 at 5:20 AM Charlie Jenkins <charlie@rivosinc.com>
wrote:

> Commit 6a04e8230707 ("RISC-V: Fix display of partial instructions")
> changed how objdump displays instructions. This enabled data of any size
> to be dumped. riscv_disassemble_data() only supports data of size 1,
> 2, 4, or 8 bytes and any other number would cause an abort.
>
> Instead of aborting when encountering one of the other values, dump the
> data as ".<N>byte <val>", similar to what is done for instructions with
> ".insn <N>, <val>".
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
> Changes in v3:
> - Move change to dis-partial-insn-word test case to first patch
> - Link to v2:
> https://lore.kernel.org/r/20250218-fix_gas_abort-v2-0-14457aa7387e@rivosinc.com
>
> Changes in v2:
> - Dump arbitrary data with ".<N>byte <val>"
> - Link to v1:
> https://lore.kernel.org/r/20250211-fix_gas_abort-v1-0-afd9730f9c51@rivosinc.com
>
> ---
> Charlie Jenkins (2):
>       RISC-V: Fix abort when displaying .dword
>       RISC-V: Add testcase for 6 byte instruction
>
>  gas/testsuite/gas/riscv/dis-partial-insn-dword.d | 12 ++++++++++++
>  gas/testsuite/gas/riscv/dis-partial-insn-dword.s |  2 ++
>  gas/testsuite/gas/riscv/dis-partial-insn-word.d  |  2 +-
>  opcodes/riscv-dis.c                              | 19 ++++++++++---------
>  4 files changed, 25 insertions(+), 10 deletions(-)
> ---
> base-commit: f1ffed29357a30162506c0c895f2927c7c2a4aba
> change-id: 20250211-fix_gas_abort-6d1e28b4ad46
> --
> - Charlie
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/binutils/attachments/20250221/bfd40b9f/attachment.htm>
More information about the Binutils mailing list