Home Original page

[PATCH v1] aarch64: Remove guarding restrictions on system registers by default.

Jan Beulich jbeulich@suse.com
Wed Jun 11 11:21:29 GMT 2025 
On 11.06.2025 13:16, Srinath Parvathaneni wrote:
> On 6/11/25 10:44, Jan Beulich wrote:
>> On 11.06.2025 11:28, Srinath Parvathaneni wrote:
>>> Regression tested for aarch64-none-elf target and found no regressions.
>>
>> Exporting a variable from a shared library is, imo, not very nice.
>> As an aside, the variable would also better be of type bool. Just
>> that struct aarch64_option_table's respective field type doesn't
>> allow for that (which hence imposes a restriction on libopcode
>> despite being gas-internal).
> 
> I agree it is not ideal to exporting variable from a shared library, but 
> the code related to system register checking is spread across multiple 
> files and I don't see an alternative.
> 
> Also use of bool seems more appropriate but aarch64_option_table doesn't 
> allow this as you have already mentioned. I tried modifying the "struct 
> aarch64_option_table" but that results in lot of unnecessary code 
> changes and also some code changes in common files.
> 
> I'm open to any suggestions, if there are any alternative ways to 
> approach this, please let me know.

For the variable exporting - introduce accessor functions instead, if
nothing better comes to mind. That'll then allow the libopcode-internal
variable to be bool, while the gas-internal one would remain to be int
(at least for the time being).

Jan
More information about the Binutils mailing list