Home Original page

[PATCH v3 1/3] AArch64, Arm and TIC6x tests: fix typo in linker scripts

Jan Beulich jbeulich@suse.com
Tue May 20 14:20:01 GMT 2025 
On 20.05.2025 16:16, Matthieu Longo wrote:
> On 2025-05-20 13:36, Jan Beulich wrote:
>> On 20.05.2025 12:34, Matthieu Longo wrote:
>>> On 2025-05-20 11:31, Matthieu Longo wrote:
>>>> The linker scripts for AArch64 and TIC6x were probably originally copied from
>>>> Arm testsuite, and contain the same typo in the name of the attributes section.
>>>>
>>>> This patch fixes the typo across all the testsuites.
>>>
>>> This looks like an obvious fix, but adding Jan in the loop for validation.
>>
>> I'd consider it obvious if you really only corrected the typos. But in a few
>> cases you're also moving respective lines (and the reason for doing so isn't
>> even mentioned in the description).
> 
> My reason for moving those lines is to sort (as much as possible) the 
> sections in a homogeneous way across all the linker scripts I saw.
> In other words, this is only cosmetics.
> 
> There are 2 tests that benefited from the lines move. I removed from the 
> match patterns things that should not matter for the tests, so we can 
> see that as an improvement.

Which is probably fine (ideally if also said in the description), but which
(as indicated) renders the change not plain obvious anymore imo. IOW please
have it ack-ed by an arch maintainer.

Jan
More information about the Binutils mailing list