Home Original page

[PATCH][binutils][2_42 2/2] x86: Check invalid TLS descriptor call TLS descriptor call,

Sadineni, Harish Harish.Sadineni@windriver.com
Wed May 21 15:43:50 GMT 2025 
>>I obviously defer to H.J. and others but the improvements to TLS
>>checking were something that we were worried would have some fallout -
>>in the end, it was fine, but I'm surprised you want to backport these?
>>What for?
>>I don't see how it's related to that CVE.


This NVD - CVE-2025-1179<https://nvd.nist.gov/vuln/detail/CVE-2025-1179> is associated with the following Bug[32640 – ld SEGV in bfd_putl64 (bfd/libbfd.c:989:11) with -w option<https://sourceware.org/bugzilla/show_bug.cgi?id=32640>] which is fixed with this patch on master branch.

Thanks,
Harish


________________________________
From: Sam James <sam@gentoo.org>
Sent: Wednesday, May 21, 2025 7:35 PM
To: Sadineni, Harish <Harish.Sadineni@windriver.com>
Cc: binutils@sourceware.org <binutils@sourceware.org>; Kokkonda, Sundeep <Sundeep.Kokkonda@windriver.com>; Dora, Sunil Kumar <SunilKumar.Dora@windriver.com>; H.J.Lu <hjl.tools@gmail.com>
Subject: Re: [PATCH][binutils][2_42 2/2] x86: Check invalid TLS descriptor call TLS descriptor call,

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Harish.Sadineni@windriver.com writes:

> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> call *x@tlsdesc(%rax)
>
> or
>
> call *x@tlsdesc(%eax)
>
> calls _dl_tlsdesc_return which expects that RAX/EAX points to the TLS
> descriptor.  Update x86 linker to issue an error with or without TLS
> transition.
>
> bfd/
>
>       PR ld/32123
>       * elf32-i386.c (elf_i386_check_tls_transition): Move
>       R_386_TLS_DESC_CALL to ...
>       (elf_i386_tls_transition): Here.
>       * elf64-x86-64.c (elf_x86_64_check_tls_transition): Move.
>       R_X86_64_TLSDESC_CALL check to ...
>       (elf_x86_64_tls_transition): Here.
>
> ld/
>
>       PR ld/32123
>       * testsuite/ld-i386/i386.exp: Run tlsgdesc3.
>       * testsuite/ld-i386/tlsgdesc3.d: New file.
>       * testsuite/ld-x86-64/tlsdesc5.d: Likewise.
>       * testsuite/ld-x86-64/x86-64.exp: Run tlsdesc5.

I obviously defer to H.J. and others but the improvements to TLS
checking were something that we were worried would have some fallout -
in the end, it was fine, but I'm surprised you want to backport these?
What for?

>
> (cherry picked from commit:67e30b15212adc1502b898a1ca224fdf65dc110d)
> CVE: CVE-2025-1179
>

I don't see how it's related to that CVE.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/binutils/attachments/20250521/035e68a1/attachment.htm>
More information about the Binutils mailing list