Message 342483 - Python tracker

Message342483

Author	xtreak
Recipients	Barry Davis, ionelmc, neologix, nikicat, pitrou, vstinner, xtreak, zwol
Date	2019-05-14.16:23:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557851026.99.0.343975134977.issue18748@roundup.psfhosted.org>
In-reply-to

Content
I was wrong so removing the close call when io_refs gets to zero causes error on test_urllib2 [0] where close is asserted to be True and I only tested test_urllib initially. One another way would be to check for fp.closed in http.client before flushing but as mentioned before I am not sure of the attribute being always present and also to modify http.client code just for tests. [0] https://github.com/python/cpython/blob/f12ba7cd0a7370631214ac0b337ab5455ce717b2/Lib/test/test_urllib2.py#L1685

Content

I was wrong so removing the close call when io_refs gets to zero causes error on test_urllib2 [0] where close is asserted to be True and I only tested test_urllib initially. One another way would be to check for fp.closed in http.client before flushing but as mentioned before I am not sure of the attribute being always present and also to modify http.client code just for tests.

[0] https://github.com/python/cpython/blob/f12ba7cd0a7370631214ac0b337ab5455ce717b2/Lib/test/test_urllib2.py#L1685

History
Date	User	Action	Args
2019-05-14 16:23:47	xtreak	set	recipients: + xtreak, pitrou, vstinner, ionelmc, neologix, nikicat, zwol, Barry Davis
2019-05-14 16:23:46	xtreak	set	messageid: <1557851026.99.0.343975134977.issue18748@roundup.psfhosted.org>
2019-05-14 16:23:46	xtreak	link	issue18748 messages
2019-05-14 16:23:46	xtreak	create