gh-92859: Doc: add info about logging.debug() calling basicConfig() by Gaasmann · Pull Request #93063 · python/cpython
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds some info about logging.debug() (and other level functions)
calling basicConfig() on behalf of the user if logging wasn't configured
beforehand.
This adds some info about logging.debug() (and other level functions) calling basicConfig() on behalf of the user if logging wasn't configured beforehand.
Thanks, I've asked for some minor tweaks.
| @@ -242,6 +242,10 @@ is the module's name in the Python package namespace. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| If no handler is attached to this logger (or its parents if | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change to
If no handler is attached to this logger (or any of its ancestors,
taking into account the relevant :attr:`Logger.propagate` attributes),
the message will be sent ...
| @@ -1038,6 +1042,9 @@ functions. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| The function will call :func:`basicConfig` if the root logger doesn't have | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to
This function (as well as :func:`info`, :func:`warning`, :func:`error` and :func:`critical`) will call ...
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.