Second blank check with root for non-existent users must never return 1 by t8m · Pull Request #300 · linux-pam/linux-pam
On Fri, Nov 20, 2020 at 05:47:05AM -0800, Tomáš Mráz wrote: > Could we just avoid assigning anything to `blank` on the second iteration? I am a little bit concerned about compiler optimization to remove some parts of the second iteration then. Although the compiler probably cannot know if the get_pwd_hash and/or _unix_run_helper_binary has any side effects. So I prefer keeping it like this.
Well, if the compiler can optimize out such calls as get_pwd_hash or _unix_run_helper_binary, then this blank check would be the least of our troubles.