Issue 12089: regrtest.py doesn't check for unexpected output anymore?
Created on 2011-05-16 15:14 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg136103 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2011-05-16 15:14 | |
In Python 3.1, a test fails if it writes to stdout/stderr. It is no more the case in Python 3.2 and 3.3. Why? If we decided to not check for unexpected output in Python 3.2+, the following code should be removed:
if verbose:
capture_stdout = None
else:
capture_stdout = io.StringIO()
|
|||
| msg136113 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2011-05-16 17:41 | |
Antoine removed that check as part of the -j support, if I recall correctly. The check for unexpected output was part of the support for the transition between the old pre-unittest test suite and the unittest based test suite, and does seem like it is obsolete. Presumably we will visually spot unexpected output during pre-checkin testing. |
|||
| msg136733 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2011-05-24 10:55 | |
@Antoine: What's your opinion? |
|||
| msg136735 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2011-05-24 10:59 | |
IMO this was all obsolete long ago, when we replaced stdout-based comparison of test results with proper assert* method calls. |
|||
| msg137327 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2011-05-30 20:58 | |
New changeset 6051f2c93163 by Victor Stinner in branch 'default': Close #12089: Remove outdated and unused code from regrtest. http://hg.python.org/cpython/rev/6051f2c93163 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:17 | admin | set | github: 56298 |
| 2011-05-30 20:58:25 | python-dev | set | status: open -> closed nosy:
+ python-dev resolution: fixed |
| 2011-05-24 10:59:23 | pitrou | set | messages: + msg136735 |
| 2011-05-24 10:55:13 | vstinner | set | messages: + msg136733 |
| 2011-05-16 17:41:51 | r.david.murray | set | nosy:
+ r.david.murray, pitrou messages: + msg136113 |
| 2011-05-16 15:51:37 | Arfrever | set | nosy:
+ Arfrever |
| 2011-05-16 15:14:04 | vstinner | create | |