Issue 17590: mingw: translate gcc internal defines to python platform specific defines
Created on 2013-03-31 19:39 by rpetrov, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0002-MINGW-translate-gcc-internal-defines-to-python-platf.patch | rpetrov, 2013-03-31 19:39 | |||
| MS_WINDOWS-move.patch | martin.panter, 2016-03-12 01:27 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg185647 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2013-03-31 19:39 | |
split of issue3871 |
|||
| msg261487 - (view) | Author: Martin Panter (martin.panter) * ![]() |
Date: 2016-03-10 09:30 | |
What’s the point of allowing each macro to already be defined? I understand they may also be defined by PC/pyconfig.h, but is that possible if __MINGW32__ is defined? Is the __MINGW32__ condition needed at all? Maybe we can just blindly rely on the _WIN32 etc macros. Perhaps the PC/pyconfig.h definitions could be removed in favour of the ones in "pyport.h"? |
|||
| msg261629 - (view) | Author: Martin Panter (martin.panter) * ![]() |
Date: 2016-03-12 01:27 | |
Here is a possible alternative patch that moves MS_WINDOWS etc from PC/pyconfig.h to "pyport.h". Not tested with standard Windows build. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:43 | admin | set | github: 61790 |
| 2021-10-21 10:00:07 | iritkatriel | set | resolution: duplicate -> wont fix |
| 2021-10-20 12:46:32 | iritkatriel | set | status: open -> closed superseder: MinGW is unsupported - close all open issues and list them here. resolution: duplicate stage: patch review -> resolved |
| 2016-03-12 01:27:26 | martin.panter | set | files:
+ MS_WINDOWS-move.patch messages:
+ msg261629 |
| 2016-03-11 21:04:42 | martin.panter | link | issue17605 dependencies |
| 2016-03-10 09:30:53 | martin.panter | set | nosy:
+ martin.panter, paul.moore, tim.golden, Alex.Willmer, zach.ware, steve.dower messages: + msg261487 components:
+ Windows |
| 2013-03-31 19:39:59 | rpetrov | create | |
