zipfile doesn't restore file attributes when extracting. Documentation should at least contain example how to do this manually, because the ony way to do this - through ZipInfo.external_attr is too cryptic.

Here is the doc - 
http://stackoverflow.com/questions/434641/how-do-i-set-permissions-attributes-on-a-file-in-a-zip-file-using-pythons-zip/6297838#6297838

I'd be +1 on extending the zipfile API in 3.4 (with a documentation update in older releases as suggested by anatoly):

* Add a method or property to ZipInfo for (un)packing 
  the external_attr field

* Add an keyword argument to Zipfile.extract and Zipfile.extractall that
  toggles restoring file permissions. This should be off by default for
  backward compatibility.

  The code that restores the file permissions should be careful to avoid
  security problems, IMHO it should by default ignore the SUID en SGID
  bits.

See also #15795

Closing this as a duplicate of #15795 (which already has a patch)

3.4+ feature is not a replacement for proper documentation for 2.7-3.4

Here's a documentation patch for 2.7 that informs the users that Zipfile.extra and Zipfile.extraall don't save permissions and that Zipfile.writestr will use ZipInfo.extra_attr or default to chmod permission set of 0600.

And here's the 3.4 and 3.5 patch

Any follow up on this?

I'm interested in this documentation enhancement as well.

Alex, I'm wondering if you could convert your patch to GitHub? [1]


[1] https://devguide.python.org/pullrequest/#converting-an-existing-patch-from-b-p-o-to-github

messages: + msg216247

messages: + msg216246

keywords: + patch

messages: + msg191456
stage: needs patch