Issue 1952: test_select.py converted to unittest
Created on 2008-01-28 01:21 by giampaolo.rodola, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_select.diff | giampaolo.rodola, 2008-01-28 01:21 | test_select.py converted to unittest | ||
| test_select.py | giampaolo.rodola, 2008-01-28 01:21 | test_select.py converted to unittest (modified .py file) | ||
| test_select.diff | giampaolo.rodola, 2008-02-06 19:05 | |||
| Messages (5) | |||
|---|---|---|---|
| msg61756 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) *  |
Date: 2008-01-28 01:21 | |
In attachment. |
|||
| msg61797 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2008-01-28 20:30 | |
The patch looks and works fine for me. Two things: 1. it's a shame the tests are skipped for windows or macintosh, but it was just the same in the original version 2. I don't think sys.platform[:3] can be equal to 'riscos' :) |
|||
| msg61798 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2008-01-28 21:19 | |
> 1. it's a shame the tests are skipped for windows or macintosh, but it
> was just the same in the original version
Yeah... I'm probably not the best person for talking about this low
level stuff but since sockets seem to be the most portable thing
accepted by select.select, maybe a listening socket could be used
instead of a process pipe.
> 2. I don't think sys.platform[:3] can be equal to 'riscos'
You're right. The original version was that way and I didn't notice it
was wrong since I've put hands on unittest stuff only.
I think this could be fine:
- if sys.platform[:3] in ('win', 'mac', 'os2', 'riscos'):
+ if sys.platform in ('win16', 'win32', 'win64', 'mac', 'os2', 'riscos'):
|
|||
| msg62117 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2008-02-06 19:05 | |
In attachment is the patch including the sys.platform change discussed above. |
|||
| msg63513 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2008-03-13 20:49 | |
Went with another test_select conversion from GHOP that added more tests. Closing as rejected. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:30 | admin | set | github: 46244 |
| 2013-11-11 11:56:09 | ncoghlan | unlink | issue19347 dependencies |
| 2013-11-11 11:55:38 | ncoghlan | link | issue19347 dependencies |
| 2008-03-13 20:49:59 | brett.cannon | set | status: open -> closed resolution: rejected messages: + msg63513 |
| 2008-02-17 22:11:48 | brett.cannon | set | assignee: brett.cannon nosy: + brett.cannon |
| 2008-02-06 19:05:37 | giampaolo.rodola | set | files:
+ test_select.diff messages: + msg62117 |
| 2008-01-28 21:19:36 | giampaolo.rodola | set | messages: + msg61798 |
| 2008-01-28 20:30:41 | pitrou | set | nosy:
+ pitrou messages: + msg61797 |
| 2008-01-28 03:36:45 | christian.heimes | set | priority: normal keywords: + patch |
| 2008-01-28 01:21:54 | giampaolo.rodola | set | files: + test_select.py |
| 2008-01-28 01:21:19 | giampaolo.rodola | create | |