There's a bad usage of `self` here:

    http://hg.python.org/cpython/file/fd846837492d/Lib/importlib/_bootstrap.py#l1431

`self` isn't defined because it's a class method.

I don't see a class method at line 1431.

Sorry, bad link, this is the right link:

http://hg.python.org/cpython/file/fd846837492d/Lib/importlib/_bootstrap.py#l1409

Thanks! :)

Here's a patch with tests that cover find_module() and find_spec() for WindowsRegistryFinder (the missing case) and fixes the bug.

The patch passes on my linux box and on my windows 7 laptop (using Visual Studio 2010 Express).

Here's an updated patch that fixes as copy-and-paste mistake.

Would it be possible to put @unittest.skipUnless(...) on WindowsRegistryFinderTests instead of duplicating it?

Except of this nit, the patch looks good to me.

Note: WindowsRegistryFinder.find_spec() contains the comment:

   # XXX untested! Need a Windows person to write tests (otherwise mock out appropriately)

New changeset 7dbb4c6cd30e by Eric Snow in branch 'default':
Issue #20097: Fix bad use of "self" in importlib's WindowsRegistryFinder.
http://hg.python.org/cpython/rev/7dbb4c6cd30e

Thanks for the review, Victor.  As to that note, it is the subject of issue #19714.

assignee: brett.cannon -> eric.snow
dependencies: - Add tests for importlib.machinery.WindowsRegistryFinder
resolution: fixed
stage: patch review -> resolved

messages: + msg207145

nosy: + eric.snow
messages: + msg207143

keywords: + patch
stage: test needed -> patch review

assignee: brett.cannon
stage: needs patch