Issue 24042: Convert os._getfullpathname() and os._isdir() to Argument Clinic
Created on 2015-04-23 19:01 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| clinic_os_getfullpathname.patch | serhiy.storchaka, 2015-04-23 19:01 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg241878 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2015-04-23 19:01 | |
Proposed patch converts os._getfullpathname() and os._isdir() to Argument Clinic. This simplifies a code and as a sided effect adds a check for embedded null character in os._getfullpathname(). The patch is not tested and can contain bugs. |
|||
| msg241880 - (view) | Author: Larry Hastings (larry) * |
Date: 2015-04-23 19:04 | |
Why isn't the patch tested? |
|||
| msg241881 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-04-23 19:34 | |
I have no Windows. |
|||
| msg242958 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-05-12 10:53 | |
Could anyone please test the patch on Windows? |
|||
| msg243022 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2015-05-12 21:39 | |
I've tested the patch on Windows 8.1, 32 and 64 bit release and debug builds with no problems. |
|||
| msg243046 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-05-13 06:46 | |
Committed in 4d7175af607e. Thank you Mark for the testing. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:16 | admin | set | github: 68230 |
| 2015-05-13 06:46:10 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg243046 stage: patch review -> resolved |
| 2015-05-12 21:39:02 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg243022 |
| 2015-05-12 10:53:47 | serhiy.storchaka | set | messages: + msg242958 |
| 2015-04-23 19:34:53 | serhiy.storchaka | set | messages: + msg241881 |
| 2015-04-23 19:04:23 | larry | set | messages: + msg241880 |
| 2015-04-23 19:01:39 | serhiy.storchaka | set | files:
+ clinic_os_getfullpathname.patch keywords: + patch |
| 2015-04-23 19:01:19 | serhiy.storchaka | link | issue24009 dependencies |
| 2015-04-23 19:01:02 | serhiy.storchaka | create | |