The man page doesn't mention PYTHONFAULTHANDER in the list of environment variables (I haven't thoroughly checked that everyone else is there, either).  I would also suggest reordering the environment variables in alphabetical order.

PYTHONASYNCIODEBUG and PYTHONTRACEMALLOC are also missing.

I didn't know that Python has a manual page :-) (Misc/python.man)

Note: I added these 3 environment variables ;-)

Hi, I have alphabetized and added the missing Environment Variables according to Section 1.2 https://docs.python.org/3.6/using/cmdline.html#environment-variables . I also added the missing environment variables from that documentation section.

Should Section 1.2 also be alphabetized? I noticed it wasn't.

This is my first contribution to python (I also just filled out the contributor forms) any comments and criticism is appreciated.

Ping.

> Hi, I have alphabetized and [...]

Can you please de-alphabetize the list to make patch review a little bit easier? Thanks!

Undid alphabetization and added additional missing environment variables including debug mode variables.

Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today.

I left some review comments on Rietveld: http://bugs.python.org/review/24459/

I have reviewed the comments on Rietveld and made the changes to the patch. Attached is the revised version.

ping

Hi Joshua,
Seems like your latest patch doesn't apply cleanly to the default branch.
Can you rebase and upload a new patch?

Thanks.

Hi I performed the rebase on the default branch.

Thanks for reviewing Mariatta I have made a new patch that has those typos corrected.

ping

Thanks for the updated patch, Joshua. I will review and commit it this week.

PYTHONUSERBASE is also missing.

Thanks for pointing out that wasn't in the latest patch this has been corrected.

Thanks for the patch and sorry for my late response. I did some tweaks and am planning to commit the tweaked version of your patch this week.

Ping

Was this ever merged? I'm not sure whats happening.

> Was this ever merged?

No.

> I'm not sure whats happening.

Hum, nothing is happening. In december, Berker wrote "Thanks for the updated patch, Joshua. I will review and commit it this week." and then it seems like he found issues, since he proposed a new patch. And then, nothing new happened. Nobody reviewed latest Berker's patch and Berker maybe forgot to push it.

Can someone pick a recent patch and convert it to a GitHub PR? Berker, the author of the most recent patch, maybe?

I am going to take the patch, edit and make a github PR for this.

Any updates on this issue are welcome. Thank you

Ignore my previous comment.
My bad.

New changeset 9863de0355caf23c44b708a5d68b603e135f7ae9 by Berker Peksag in branch 'master':
bpo-24459: Document missing env variables in python.man (GH-4142)
https://github.com/python/cpython/commit/9863de0355caf23c44b708a5d68b603e135f7ae9

New changeset 22fb674fa4c8343c84c25d93f23a1d6315d0f4f5 by Miss Islington (bot) in branch '3.7':
bpo-24459: Document missing env variables in python.man (GH-4142)
https://github.com/python/cpython/commit/22fb674fa4c8343c84c25d93f23a1d6315d0f4f5

Thanks, Joshua!

resolution: fixed
stage: patch review -> resolved

messages: + msg287116

messages: + msg281245

messages: + msg278425

messages: + msg278395

messages: + msg267470

messages: + msg267167

messages: + msg267159
stage: needs patch -> patch review

nosy: + zitterbewegung
messages: + msg266032

keywords: + patch