Issue 32262: Fix linting errors in asyncio code; use f-strings consistently
Created on 2017-12-09 21:35 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4775 | merged | yselivanov, 2017-12-09 21:41 | |
| PR 4787 | merged | yselivanov, 2017-12-11 00:34 | |
| PR 7016 | merged | christian.heimes, 2018-05-20 15:48 | |
| PR 7018 | merged | miss-islington, 2018-05-20 17:58 | |
| Messages (7) | |||
|---|---|---|---|
| msg307929 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2017-12-09 23:26 | |
Usually we don't do such kind of changes. This spoils the output of `git annotate` and `git blame` and makes harder researching the history. |
|||
| msg307938 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-10 01:56 | |
I think it's OK. I want asyncio code to stay modern and up to date. git blame is not a problem here, as only one-two lines are changed per function. Code consistency is more important. |
|||
| msg307949 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2017-12-10 09:35 | |
Agree with Yury, at lease for asyncio library. |
|||
| msg308005 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-10 23:36 | |
New changeset 6370f345e1d5829e1fba59cd695c8b82c5a8c620 by Yury Selivanov in branch 'master': bpo-32262: Fix codestyle; use f-strings formatting where necessary. (#4775) https://github.com/python/cpython/commit/6370f345e1d5829e1fba59cd695c8b82c5a8c620 |
|||
| msg308010 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-11 00:52 | |
New changeset 19d0d5480931117d9e0bf396a0234707bbdaa494 by Yury Selivanov in branch 'master': bpo-32262: Fix f-string (#4787) https://github.com/python/cpython/commit/19d0d5480931117d9e0bf396a0234707bbdaa494 |
|||
| msg317194 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2018-05-20 17:57 | |
New changeset d361e99868a9eaa7ffce9341e1207705dbb66b50 by Christian Heimes in branch 'master': bpo-32262: Fix typo in f-string (GH-7016) https://github.com/python/cpython/commit/d361e99868a9eaa7ffce9341e1207705dbb66b50 |
|||
| msg317196 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2018-05-20 18:22 | |
New changeset b85115ed4c5d4e80ab818b44401e71299de9e9a5 by Christian Heimes (Miss Islington (bot)) in branch '3.7': [3.7] bpo-32262: Fix typo in f-string (GH-7016) https://github.com/python/cpython/commit/b85115ed4c5d4e80ab818b44401e71299de9e9a5 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:55 | admin | set | github: 76443 |
| 2018-05-20 18:22:58 | christian.heimes | set | messages: + msg317196 |
| 2018-05-20 17:58:24 | miss-islington | set | pull_requests: + pull_request6669 |
| 2018-05-20 17:57:15 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg317194 |
| 2018-05-20 15:48:41 | christian.heimes | set | pull_requests: + pull_request6666 |
| 2017-12-11 00:52:55 | yselivanov | set | messages: + msg308010 |
| 2017-12-11 00:34:19 | yselivanov | set | pull_requests: + pull_request4688 |
| 2017-12-10 23:36:37 | yselivanov | set | status: open -> closed type: enhancement resolution: fixed stage: patch review -> resolved |
| 2017-12-10 23:36:14 | yselivanov | set | messages: + msg308005 |
| 2017-12-10 09:35:42 | asvetlov | set | messages: + msg307949 |
| 2017-12-10 01:56:28 | yselivanov | set | messages: + msg307938 |
| 2017-12-09 23:26:09 | serhiy.storchaka | set | nosy:
+ rhettinger, serhiy.storchaka, pitrou messages: + msg307929 |
| 2017-12-09 21:41:27 | yselivanov | set | keywords:
+ patch stage: patch review pull_requests: + pull_request4676 |
| 2017-12-09 21:35:26 | yselivanov | set | nosy:
+ asvetlov |
| 2017-12-09 21:35:20 | yselivanov | create | |