Issue32635
Created on 2018-01-23 10:22 by cstratak, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 00290-cryptmodule-Include-crypt.h-for-declaration-of-crypt.patch | cstratak, 2018-01-23 10:22 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5284 | merged | cstratak, 2018-01-23 12:15 | |
| PR 5295 | merged | python-dev, 2018-01-24 09:36 | |
| PR 5296 | merged | python-dev, 2018-01-24 09:36 | |
| Messages (10) | |||
|---|---|---|---|
| msg310490 - (view) | Author: Charalampos Stratakis (cstratak) * | Date: 2018-01-23 10:22 | |
Currently in Fedora glibc stopped providing libcrypt[0] a change which is slowly being upstreamed as well[1] in favor of the libxcrypt project[2]. This causes a segfault when importing the crypt module as python assumes that crypt.h is always available. Providing a working patch from the libxcrypt maintainer. I'll convert the patch into a PR. [0] https://fedoraproject.org/wiki/Changes/Replace_glibc_libcrypt_with_libxcrypt [1] https://sourceware.org/ml/libc-alpha/2017-08/msg01257.html [2] https://github.com/besser82/libxcrypt |
|||
| msg310503 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2018-01-23 15:11 | |
New changeset e768c86ef442ef89004089a8a34ce5909ffb90f2 by Victor Stinner (stratakis) in branch 'master': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (#5284) https://github.com/python/cpython/commit/e768c86ef442ef89004089a8a34ce5909ffb90f2 |
|||
| msg310563 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2018-01-24 05:41 | |
Incidentally, why did this manifest as a segfault rather than a compilation error? |
|||
| msg310573 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-01-24 09:42 | |
Charalampos, Christian: are you ok to backport the fix to Python 2.7 and 3.6? (PR 5295 and PR 5296) |
|||
| msg310575 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2018-01-24 09:42 | |
yes, go ahead |
|||
| msg310579 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-01-24 09:51 | |
New changeset 6ccdad7b1f6fb316e4e85aa1eba8fbdc3169741e by Victor Stinner (Miss Islington (bot)) in branch '2.7': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) (#5295) https://github.com/python/cpython/commit/6ccdad7b1f6fb316e4e85aa1eba8fbdc3169741e |
|||
| msg310581 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-01-24 10:11 | |
New changeset 8e230e1eb3d38ad557b5dc5c31166afa35c01ff3 by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) (#5296) https://github.com/python/cpython/commit/8e230e1eb3d38ad557b5dc5c31166afa35c01ff3 |
|||
| msg397959 - (view) | Author: Geoffrey Thomas (geofft) * | Date: 2021-07-21 19:14 | |
Sorry to bump an old thread, but - does <crypt.h> need to be in the public Python.h header? Or would it be enough to be in _cryptmodule.c, which is the code that uses crypt_r()? I can provide a quick patch to change that if that seems sound. |
|||
| msg398254 - (view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) *  |
Date: 2021-07-26 19:38 | |
Geoffrey Thomas: I agree that including crypt.h only where required is better. Can you file new bug with patch? Benjamin Peterson: I suspect that with crypt.h not included in _cryptmodule.c, crypt() was treated by compiler as implicitly declared function (returning 'int'), however real crypt() function returns 'char*'. |
|||
| msg398322 - (view) | Author: Geoffrey Thomas (geofft) * | Date: 2021-07-27 21:33 | |
Opened #44751 and https://github.com/python/cpython/pull/27394 . |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:56 | admin | set | github: 76816 |
| 2021-07-27 21:33:23 | geofft | set | messages: + msg398322 |
| 2021-07-26 19:38:23 | Arfrever | set | nosy:
+ Arfrever messages: + msg398254 |
| 2021-07-21 19:14:19 | geofft | set | nosy:
+ geofft messages: + msg397959 |
| 2018-01-24 13:30:26 | cstratak | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-01-24 10:11:19 | vstinner | set | messages: + msg310581 |
| 2018-01-24 09:51:41 | vstinner | set | messages: + msg310579 |
| 2018-01-24 09:42:58 | christian.heimes | set | messages: + msg310575 |
| 2018-01-24 09:42:00 | vstinner | set | nosy:
+ christian.heimes messages: + msg310573 |
| 2018-01-24 09:36:57 | python-dev | set | pull_requests: + pull_request5143 |
| 2018-01-24 09:36:02 | python-dev | set | pull_requests: + pull_request5142 |
| 2018-01-24 09:35:33 | vstinner | set | versions: + Python 2.7, - Python 3.8 |
| 2018-01-24 05:41:18 | benjamin.peterson | set | nosy:
+ benjamin.peterson messages: + msg310563 |
| 2018-01-23 15:11:26 | vstinner | set | messages: + msg310503 |
| 2018-01-23 12:42:33 | vstinner | set | nosy:
+ vstinner |
| 2018-01-23 12:15:43 | cstratak | set | stage: patch review pull_requests: + pull_request5130 |
| 2018-01-23 10:28:39 | cstratak | set | components: + Extension Modules |
| 2018-01-23 10:28:26 | cstratak | set | versions: + Python 3.6, Python 3.7, Python 3.8 |
| 2018-01-23 10:22:06 | cstratak | create | |