Issue32829
Created on 2018-02-12 12:06 by dilyan.palauzov, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg312040 - (view) | Author: Дилян Палаузов (dilyan.palauzov) | Date: 2018-02-12 12:06 | |
diff --git a/Lib/distutils/command/sdist.py b/Lib/distutils/command/sdist.py
--- a/Lib/distutils/command/sdist.py
+++ b/Lib/distutils/command/sdist.py
@@ -251,14 +251,11 @@ class sdist(Command):
for fn in standards:
if isinstance(fn, tuple):
alts = fn
- got_it = False
for fn in alts:
if self._cs_path_exists(fn):
- got_it = True
self.filelist.append(fn)
break
-
- if not got_it:
+ else:
self.warn("standard file not found: should have one of " +
', '.join(alts))
else:
diff --git a/Lib/email/_header_value_parser.py b/Lib/email/_header_value_parser.py
--- a/Lib/email/_header_value_parser.py
+++ b/Lib/email/_header_value_parser.py
@@ -567,14 +567,7 @@ class DisplayName(Phrase):
@property
def value(self):
- quote = False
- if self.defects:
- quote = True
- else:
- for x in self:
- if x.token_type == 'quoted-string':
- quote = True
- if quote:
+ if self.defects or any(x.token_type == 'quoted-string' for x in self):
pre = post = ''
if self[0].token_type=='cfws' or self[0][0].token_type=='cfws':
pre = ' '
diff --git a/Lib/idlelib/config.py b/Lib/idlelib/config.py
--- a/Lib/idlelib/config.py
+++ b/Lib/idlelib/config.py
@@ -402,7 +402,7 @@ class IdleConf:
because setting 'name' to a builtin not defined in older IDLEs
to display multiple error messages or quit.
See https://bugs.python.org/issue25313.
- When default = True, 'name2' takes precedence over 'name',
+ When default is True, 'name2' takes precedence over 'name',
while older IDLEs will just use name. When default = False,
'name2' may still be set, but it is ignored.
"""
|
|||
| msg312041 - (view) | Author: Christian Heimes (christian.heimes) * ![]() |
Date: 2018-02-12 12:09 | |
We generally don't accept patches on bugs.python.org. Please open a pull request on github, see https://devguide.python.org/#contributing |
|||
| msg312253 - (view) | Author: Terry J. Reedy (terry.reedy) * ![]() |
Date: 2018-02-16 21:09 | |
Dilyan, please explain what you believe the problems to be and how the patch solves it. These seem to be 3 separate issues. Do not change idlelib.config. config_main.def contain 'default = True' or 'default = False' and that is what the docstring references. |
|||
| msg313270 - (view) | Author: Дилян Палаузов (dilyan.palauzov) | Date: 2018-03-05 17:09 | |
The variables got_it in distutils/command/sdist and quote in email/_header_value_parser can be skipped making the code shorter and faster. |
|||
| msg314009 - (view) | Author: R. David Murray (r.david.murray) * ![]() |
Date: 2018-03-17 18:07 | |
The risk of introducing a bug is higher than the minimal benefit of making the changes. Thus we do not typically accept changes like this. We'll clean up such code when we touching it for other reasons. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:57 | admin | set | github: 77010 |
| 2018-03-17 18:07:58 | r.david.murray | set | status: open -> closed nosy:
+ r.david.murray resolution: rejected |
| 2018-03-05 17:09:06 | dilyan.palauzov | set | messages: + msg313270 |
| 2018-02-16 21:09:35 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg312253 |
| 2018-02-12 12:09:38 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg312041 |
| 2018-02-12 12:06:40 | dilyan.palauzov | create | |
