Issue 33295: ERROR: test_sites_no_connection_close (test.test_urllib2net.OtherNetworkTests)
Created on 2018-04-17 09:15 by methane, last changed 2022-04-11 14:58 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6504 | merged | methane, 2018-04-17 11:01 | |
| PR 6509 | merged | miss-islington, 2018-04-17 15:32 | |
| PR 6510 | merged | miss-islington, 2018-04-17 15:33 | |
| PR 6511 | merged | miss-islington, 2018-04-17 15:34 | |
| Messages (7) | |||
|---|---|---|---|
| msg315384 - (view) | Author: Inada Naoki (methane) *  |
Date: 2018-04-17 09:15 | |
https://github.com/python/cpython/blob/5fbc511f56688654a05b9eba23d140318bb9b2d5/Lib/test/test_urllib2net.py#L180-L198 This test uses http://www.imdb.com/, but it is gone. So This test start failing. Is there any good URL for this test case? May I skip this test for now? |
|||
| msg315399 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2018-04-17 15:31 | |
New changeset 36d56ea826caffbeac0fc0c6d90248b80516e33c by Ned Deily (INADA Naoki) in branch 'master': bpo-33295: Skip test using missing external site (GH-6504) https://github.com/python/cpython/commit/36d56ea826caffbeac0fc0c6d90248b80516e33c |
|||
| msg315400 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2018-04-17 15:33 | |
New changeset f7379ddf1c315fe18734cca943aff5b437baf849 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-33295: Skip test using missing external site (GH-6504) (GH-6509) https://github.com/python/cpython/commit/f7379ddf1c315fe18734cca943aff5b437baf849 |
|||
| msg315401 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2018-04-17 15:35 | |
New changeset afc768d69879d6b95c59a0a5e92ea4c6061f3841 by Ned Deily (Miss Islington (bot)) in branch '2.7': bpo-33295: Skip test using missing external site (GH-6504) (GH-6510) https://github.com/python/cpython/commit/afc768d69879d6b95c59a0a5e92ea4c6061f3841 |
|||
| msg315402 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2018-04-17 15:36 | |
New changeset f1547d110ff195291e29ba5c29617912d12ecbec by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-33295: Skip test using missing external site (GH-6504) (GH-6511) https://github.com/python/cpython/commit/f1547d110ff195291e29ba5c29617912d12ecbec |
|||
| msg315403 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2018-04-17 15:38 | |
Thanks! I force-merged the skips of the test so that Travis CI and buildbots were not failing. I'll leave the issue open so we can decide what to do about the test long term. |
|||
| msg315404 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2018-04-17 15:39 | |
I initially thought about using pythontest.net but I don't think it's possible to remove the Connection header at the nginx level: https://github.com/python/psf-salt/blob/master/salt/pythontest/config/nginx.pythontest.conf.jinja I think our only option is to create a local server for the test. I'm not sure it's an important enough use case, though. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:59 | admin | set | github: 77476 |
| 2018-04-17 15:39:22 | berker.peksag | set | nosy:
+ berker.peksag, orsenthil type: behavior messages: + msg315404 |
| 2018-04-17 15:38:46 | ned.deily | set | messages: + msg315403 |
| 2018-04-17 15:36:32 | ned.deily | set | messages: + msg315402 |
| 2018-04-17 15:35:38 | ned.deily | set | messages: + msg315401 |
| 2018-04-17 15:34:42 | miss-islington | set | pull_requests: + pull_request6204 |
| 2018-04-17 15:33:51 | ned.deily | set | messages: + msg315400 |
| 2018-04-17 15:33:41 | miss-islington | set | pull_requests: + pull_request6203 |
| 2018-04-17 15:32:40 | miss-islington | set | pull_requests: + pull_request6202 |
| 2018-04-17 15:31:32 | ned.deily | set | nosy:
+ ned.deily messages: + msg315399 |
| 2018-04-17 11:01:28 | methane | set | keywords:
+ patch stage: patch review pull_requests: + pull_request6200 |
| 2018-04-17 09:15:32 | methane | create | |