Issue 33534: dataclasses: unneeded test in _is_classvar
Created on 2018-05-16 08:04 by eric.smith, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6897 | merged | eric.smith, 2018-05-16 09:26 | |
| PR 6899 | merged | miss-islington, 2018-05-16 11:25 | |
| Messages (3) | |||
|---|---|---|---|
| msg316779 - (view) | Author: Eric V. Smith (eric.smith) *  |
Date: 2018-05-16 08:04 | |
There's an unnecessary test for "if typing" in _is_classvar. I added this function yesterday, and due to some refactoring it picked up some superfluous text. I'm going to remove it. |
|||
| msg316797 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2018-05-16 11:24 | |
New changeset 9285835a05ad0319acef111340266c0f85ed549c by Eric V. Smith in branch 'master': bpo-33534: Remove unneeded test. (GH-6897) https://github.com/python/cpython/commit/9285835a05ad0319acef111340266c0f85ed549c |
|||
| msg316800 - (view) | Author: miss-islington (miss-islington) | Date: 2018-05-16 11:46 | |
New changeset 8e20fc388f1f1e6b2b38bf11995322c274b4d43a by Miss Islington (bot) in branch '3.7': bpo-33534: Remove unneeded test. (GH-6897) https://github.com/python/cpython/commit/8e20fc388f1f1e6b2b38bf11995322c274b4d43a |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:00 | admin | set | github: 77715 |
| 2018-05-16 11:56:09 | eric.smith | set | priority: release blocker -> status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-05-16 11:46:39 | miss-islington | set | nosy:
+ miss-islington messages: + msg316800 |
| 2018-05-16 11:25:16 | miss-islington | set | pull_requests: + pull_request6569 |
| 2018-05-16 11:24:10 | eric.smith | set | messages: + msg316797 |
| 2018-05-16 09:26:32 | eric.smith | set | keywords:
+ patch stage: patch review pull_requests: + pull_request6567 |
| 2018-05-16 08:04:01 | eric.smith | create | |