Issue33845
➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-06-12 15:06 by adelfino, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 7667 | merged | adelfino, 2018-06-12 15:06 | |
| Messages (6) | |||
|---|---|---|---|
| msg319392 - (view) | Author: Andrés Delfino (adelfino) *  |
Date: 2018-06-12 15:06 | |
PR makes the necessary changes to make Doc\make.bat the same as the master version, except some small differences. This should help backports. |
|||
| msg319412 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2018-06-12 23:34 | |
Hopefully there aren't that many more fixes needed to this scripts - you've done a great job clearing up the issues! Any reason not to merge right now? I notice your commit message simply reads "Initial commit" |
|||
| msg319414 - (view) | Author: Andrés Delfino (adelfino) * |
Date: 2018-06-13 00:02 | |
Not really. I name all my first commits "Initial commit" as you gals/guys rename it anyways, and, also, it's usual to be asked for changes :) I might change my mind after my initial commit, but I only make pull requests when the first commit _seems_ final to me at the time. PS: Thank you for your words! :) |
|||
| msg319415 - (view) | Author: Andrés Delfino (adelfino) * |
Date: 2018-06-13 00:03 | |
I think I wasn't clear: I see no reason to not merge this right now. |
|||
| msg319416 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2018-06-13 00:31 | |
New changeset 42ca8367ceb59021bbf5e5fb4fd0268d3411c0a4 by Steve Dower (Andrés Delfino) in branch '2.7': bpo-33845: Update Doc\make.bat on 2.7 to bring it on par to master version (GH-7667) https://github.com/python/cpython/commit/42ca8367ceb59021bbf5e5fb4fd0268d3411c0a4 |
|||
| msg319417 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2018-06-13 00:31 | |
Merged! We don't normally change the name (except to update the GH-7667 reference at the end), but once there's more than one commit GitHub will use the PR title instead of the commit message. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:01 | admin | set | github: 78026 |
| 2018-06-13 00:32:00 | steve.dower | set | status: open -> closed messages: + msg319417 assignee: steve.dower |
| 2018-06-13 00:31:07 | steve.dower | set | messages: + msg319416 |
| 2018-06-13 00:03:35 | adelfino | set | messages: + msg319415 |
| 2018-06-13 00:02:28 | adelfino | set | messages: + msg319414 |
| 2018-06-12 23:34:52 | steve.dower | set | messages: + msg319412 |
| 2018-06-12 15:06:58 | adelfino | set | keywords:
+ patch stage: patch review pull_requests: + pull_request7282 |
| 2018-06-12 15:06:34 | adelfino | create | |