Messages (8) msg320133 - (view) Author: Terry J. Reedy (terry.reedy) * Date: 2018-06-21 02:06

Some time ago, IDLE's main menu item 'Windows' was changed to 'Window'.  The latter seems to be pretty standard for a list of open windows.  Issue #33906 changed the implementation module name accordingly, from 'windows' to 'window'.  This issue is about changing the 'windows' key in mainmenu.menudef to 'window'. All other keys are the lower case version of the uppercase menu item.

editor subscripts derived menudict with ['windows'] and menu_specs, which maps menudef keys to menu names, includes ('windows': '_Window'). pyshell also has menu_specs

Function and pseudoevent names that include 'windows'should be left alone.

Besides the automated tests passing, the manual test will be that 'Window' works properly in all of Shell, editor window, and output window, as each is added.

msg320135 - (view) Author: Terry J. Reedy (terry.reedy) * Date: 2018-06-21 02:50

New changeset 33c7420e7dd9d8e5b2aa15e98da6291bab6fcf33 by Terry Jan Reedy in branch 'master':
 bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
https://github.com/python/cpython/commit/33c7420e7dd9d8e5b2aa15e98da6291bab6fcf33

msg320137 - (view) Author: miss-islington (miss-islington) Date: 2018-06-21 04:35

New changeset e1f0dceb266ae66a3b8ea9d087266f3960c59b2d by Miss Islington (bot) in branch '3.7':
bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
https://github.com/python/cpython/commit/e1f0dceb266ae66a3b8ea9d087266f3960c59b2d

msg320138 - (view) Author: miss-islington (miss-islington) Date: 2018-06-21 04:41

New changeset 06deaf44d05471d9438502706cc09bb0e2ad3216 by Miss Islington (bot) in branch '3.6':
bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
https://github.com/python/cpython/commit/06deaf44d05471d9438502706cc09bb0e2ad3216

msg320460 - (view) Author: Terry J. Reedy (terry.reedy) * Date: 2018-06-26 01:19

New changeset 42397731d7ba8bdf63025d48008d133cb2070229 by Terry Jan Reedy (Mark Roseman) in branch 'master':
bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
https://github.com/python/cpython/commit/42397731d7ba8bdf63025d48008d133cb2070229

msg320461 - (view) Author: miss-islington (miss-islington) Date: 2018-06-26 01:37

New changeset ee60e36fbf640e9e2ab6cd26821aad5d90529d96 by Miss Islington (bot) in branch '3.7':
bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
https://github.com/python/cpython/commit/ee60e36fbf640e9e2ab6cd26821aad5d90529d96

msg320462 - (view) Author: miss-islington (miss-islington) Date: 2018-06-26 01:42

New changeset c6040638aa1537709add895d24cdbbb9ee310fde by Miss Islington (bot) in branch '3.6':
bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
https://github.com/python/cpython/commit/c6040638aa1537709add895d24cdbbb9ee310fde

msg320463 - (view) Author: Terry J. Reedy (terry.reedy) * Date: 2018-06-26 01:52

Mark's PR added two conversions, in macosx, that I missed.  I rechecked a recursive case sensitive whole-word grep of 'windows' in idlelib and I believe all remaining occurrences refer to the Windows OS (usually capitalized) or multiple windows.

History Date User Action Args 2022-04-11 14:59:02adminsetgithub: 78105 2018-06-26 01:52:29terry.reedysetmessages: + msg320463 2018-06-26 01:42:12miss-islingtonsetmessages: + msg320462 2018-06-26 01:37:49miss-islingtonsetmessages: + msg320461 2018-06-26 01:21:51miss-islingtonsetpull_requests: + pull_request7531 2018-06-26 01:20:58miss-islingtonsetpull_requests: + pull_request7530 2018-06-26 01:19:48terry.reedysetmessages: + msg320460 2018-06-25 23:55:12markrosemansetpull_requests: + pull_request7526 2018-06-21 05:59:37terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved 2018-06-21 04:41:00miss-islingtonsetmessages: + msg320138 2018-06-21 04:35:53miss-islingtonsetnosy: + miss-islington
messages: + msg320137
2018-06-21 02:51:07miss-islingtonsetpull_requests: + pull_request7447 2018-06-21 02:50:10miss-islingtonsetpull_requests: + pull_request7446 2018-06-21 02:50:04terry.reedysetmessages: + msg320135 2018-06-21 02:26:21terry.reedysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7445 2018-06-21 02:06:39terry.reedycreate