Issue34248
Created on 2018-07-27 13:33 by sam-s, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch.diff | csernazs, 2018-07-31 20:19 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8590 | merged | csernazs, 2018-07-31 20:56 | |
| Messages (6) | |||
|---|---|---|---|
| msg322492 - (view) | Author: sds (sam-s) | Date: 2018-07-27 13:33 | |
`dbm` errors should contain file names when appropriate, just like `OSError`.
E.g.:
```
>>> open("fooooo")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
FileNotFoundError: [Errno 2] No such file or directory: 'fooooo'
>>> import dbm.gnu
>>> dbm.gnu.open("fooooo")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
_gdbm.error: [Errno 2] No such file or directory
```
the `_gdbm.error` should report the file name `'fooooo'` just like `FileNotFoundError` does (and `exn.args` should contain the file name too!)
|
|||
| msg322815 - (view) | Author: Zsolt Cserna (csernazs) * | Date: 2018-07-31 20:19 | |
I've made a patch which works for me.
>>> dbm.gnu.open("/tmp/zzzzz")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
_gdbm.error: [Errno 2] No such file or directory: '/tmp/zzzzz'
>>>
Could you please give it a try?
|
|||
| msg322816 - (view) | Author: sds (sam-s) | Date: 2018-07-31 20:37 | |
thanks for the patch. alas, I do not build python myself, so I cannot try it. |
|||
| msg322821 - (view) | Author: Zsolt Cserna (csernazs) * | Date: 2018-07-31 21:01 | |
Alright, I created a PR for this. We will see if this can be merged to upstream or not. |
|||
| msg323178 - (view) | Author: Berker Peksag (berker.peksag) * ![]() |
Date: 2018-08-06 06:28 | |
PR 8590 only changes dbm.gnu. If we do this, we should update dbm.ndbm as well: https://github.com/python/cpython/blob/4a745333406a4b9c5b0194bdac4a77d9fadd5457/Modules/_dbmmodule.c#L65 |
|||
| msg326590 - (view) | Author: Berker Peksag (berker.peksag) * ![]() |
Date: 2018-09-27 19:54 | |
New changeset 9df346bf98069a87de14a3c2f69009d800994c63 by Berker Peksag (Zsolt Cserna) in branch 'master': bpo-34248: Add filename to error raised in {gnu,ndbm}.open() (GH-8590) https://github.com/python/cpython/commit/9df346bf98069a87de14a3c2f69009d800994c63 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:03 | admin | set | github: 78429 |
| 2018-09-27 19:55:04 | berker.peksag | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-09-27 19:54:38 | berker.peksag | set | messages: + msg326590 |
| 2018-08-06 06:28:35 | berker.peksag | set | versions:
- Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 nosy: + berker.peksag messages: + msg323178 type: enhancement |
| 2018-07-31 21:01:48 | csernazs | set | messages: + msg322821 |
| 2018-07-31 20:56:26 | csernazs | set | stage: patch review pull_requests: + pull_request8100 |
| 2018-07-31 20:37:55 | sam-s | set | messages: + msg322816 |
| 2018-07-31 20:19:59 | csernazs | set | files:
+ patch.diff nosy:
+ csernazs keywords: + patch |
| 2018-07-27 13:33:58 | sam-s | create | |
