Issue34442
Created on 2018-08-20 14:40 by steveire, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Messages (4) | |||
|---|---|---|---|
| msg323791 - (view) | Author: Stephen Kelly (steveire) | Date: 2018-08-20 14:40 | |
I tried to build python 3.7.0 from source. I ran the PCBuild/build.bat script. That downloaded zlib to the external/ directory. However, it does not seem to be built. When running I get: python\3.7.0\lib\zipfile.py", line 646, in _check_compression "Compression requires the (missing) zlib module") RuntimeError: Compression requires the (missing) zlib module I examined PCBuild/pcbuild.proj. It makes no mention of zlib, though it mentions other externals. I notice that Python 3.6.1 contained zlib in Modules/zlib instead of coming from external/. Presumably that source was moved, but the Windows-related scripts were not updated. |
|||
| msg323793 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2018-08-20 15:08 | |
Hi Stephen, zlib is built into the core binary (pythonXY.dll) when you build with `IncludeExternals`; see PCbuild/pythoncore.vcxproj. Using PCbuild/build.bat should do that automatically (unless you tell it not to), but if it's not we may need to fix something. |
|||
| msg324035 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2018-08-25 02:32 | |
What precisely does 'running' mean, so that we can try to reproduce? python -m test.test_zipfile Runs 208/207 tests in about a minute on the repository debug builds without failure for both 3.8 and 3.7. |
|||
| msg341215 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2019-05-01 16:16 | |
With no further explanation of what went wrong, I'm closing the issue. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:04 | admin | set | github: 78623 |
| 2019-05-01 16:16:12 | zach.ware | set | status: open -> closed resolution: works for me messages: + msg341215 stage: test needed -> resolved |
| 2018-08-25 02:32:27 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg324035 |
| 2018-08-20 15:08:56 | zach.ware | set | nosy:
+ paul.moore, tim.golden, zach.ware, steve.dower messages: + msg323793 components:
+ Windows |
| 2018-08-20 14:40:14 | steveire | create | |