Issue35374
Created on 2018-12-02 09:42 by chrullrich, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10849 | merged | chrullrich, 2018-12-02 09:43 | |
| PR 11464 | merged | miss-islington, 2019-01-08 02:58 | |
| PR 11464 | merged | miss-islington, 2019-01-08 02:58 | |
| PR 11464 | merged | miss-islington, 2019-01-08 02:58 | |
| Messages (3) | |||
|---|---|---|---|
| msg330872 - (view) | Author: Christian Ullrich (chrullrich) * | Date: 2018-12-02 09:42 | |
If hhc.exe is on the PATH when HTML Help is being built, the build fails because make.bat does not correctly remember the fact. The set command is very finicky with trailing spaces, leading to this: '"hhc "' is not recognized as an internal or external command, operable program or batch file. I suppose the "official" build does not rely on autodetection. In that case, a better fix would be to require setting HTMLHELP explicitly. PR (for the single-character fix) incoming. |
|||
| msg333205 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2019-01-08 02:57 | |
New changeset e61cc481e02b758c8d8289163102c236d0658a55 by Steve Dower (chrullrich) in branch 'master': bpo-35374: Avoid trailing space in hhc file name if found on PATH. (GH-10849) https://github.com/python/cpython/commit/e61cc481e02b758c8d8289163102c236d0658a55 |
|||
| msg333206 - (view) | Author: miss-islington (miss-islington) | Date: 2019-01-08 03:04 | |
New changeset 5d1e0124cf562153a681d1b5b362e7c8e23edea9 by Miss Islington (bot) in branch '3.7': bpo-35374: Avoid trailing space in hhc file name if found on PATH. (GH-10849) https://github.com/python/cpython/commit/5d1e0124cf562153a681d1b5b362e7c8e23edea9 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:08 | admin | set | github: 79555 |
| 2019-01-08 03:23:08 | steve.dower | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-01-08 03:04:17 | miss-islington | set | nosy:
+ miss-islington messages: + msg333206 |
| 2019-01-08 02:58:29 | miss-islington | set | pull_requests: + pull_request10952 |
| 2019-01-08 02:58:19 | miss-islington | set | pull_requests: + pull_request10951 |
| 2019-01-08 02:58:07 | miss-islington | set | pull_requests: + pull_request10950 |
| 2019-01-08 02:57:35 | steve.dower | set | messages: + msg333205 |
| 2018-12-02 12:41:32 | eryksun | set | nosy:
+ eryksun |
| 2018-12-02 10:40:49 | xtreak | set | nosy:
+ paul.moore, tim.golden, zach.ware, steve.dower components: + Windows |
| 2018-12-02 09:43:29 | chrullrich | set | keywords:
+ patch stage: patch review pull_requests: + pull_request10084 |
| 2018-12-02 09:42:08 | chrullrich | create | |