Issue35602
Created on 2018-12-28 04:21 by pablogsal, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11338 | merged | pablogsal, 2018-12-28 04:23 | |
| PR 11338 | merged | pablogsal, 2018-12-28 04:23 | |
| PR 11338 | merged | pablogsal, 2018-12-28 04:23 | |
| PR 11358 | merged | miss-islington, 2018-12-29 19:19 | |
| PR 11358 | merged | miss-islington, 2018-12-29 19:19 | |
| PR 11358 | merged | miss-islington, 2018-12-29 19:19 | |
| Messages (3) | |||
|---|---|---|---|
| msg332642 - (view) | Author: Pablo Galindo Salgado (pablogsal) * ![]() |
Date: 2018-12-28 04:21 | |
According to this buildbot: https://buildbot.python.org/all/#/builders/170/builds/218/steps/4/logs/stdio there is some cleanup failure in test_sock_sendfile_os_error_first_call: test_sock_sendfile_os_error_first_call (test.test_asyncio.test_unix_events.SelectorEventLoopUnixSockSendfileTests) ... /usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/asyncio/selector_events.py:655: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=10> source=self) ResourceWarning: Enable tracemalloc to get the object allocation traceback ok The code that is supposed to clean up the resource is: def cleanup(): if proto.transport is not None: # can be None if the task was cancelled before # connection_made callback proto.transport.close() self.run_loop(proto.wait_closed()) apparently, proto.transport may be None and then it fails to be closed even if the test succeeds (I assume because the condition in the comment happens or something else) and then the transport is not properly closed. |
|||
| msg332729 - (view) | Author: Pablo Galindo Salgado (pablogsal) * ![]() |
Date: 2018-12-29 19:18 | |
New changeset d51324a2f5d172665f8824b25456c9822797fc84 by Pablo Galindo in branch 'master': bpo-35602: Make sure the transport is always closed in SelectorEventLoopUnixSockSendfileTests (GH-11338) https://github.com/python/cpython/commit/d51324a2f5d172665f8824b25456c9822797fc84 |
|||
| msg332731 - (view) | Author: miss-islington (miss-islington) | Date: 2018-12-29 19:38 | |
New changeset fe06646d186780881fa5ee61442886a6d7cf9f08 by Miss Islington (bot) in branch '3.7': bpo-35602: Make sure the transport is always closed in SelectorEventLoopUnixSockSendfileTests (GH-11338) https://github.com/python/cpython/commit/fe06646d186780881fa5ee61442886a6d7cf9f08 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:09 | admin | set | github: 79783 |
| 2018-12-29 20:14:04 | pablogsal | set | keywords:
patch, patch, patch status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-12-29 19:38:26 | miss-islington | set | nosy:
+ miss-islington messages: + msg332731 |
| 2018-12-29 19:19:16 | miss-islington | set | pull_requests: + pull_request10675 |
| 2018-12-29 19:19:09 | miss-islington | set | pull_requests: + pull_request10674 |
| 2018-12-29 19:19:02 | miss-islington | set | pull_requests: + pull_request10673 |
| 2018-12-29 19:18:42 | pablogsal | set | messages: + msg332729 |
| 2018-12-28 04:23:48 | pablogsal | set | keywords:
+ patch stage: patch review pull_requests: + pull_request10617 |
| 2018-12-28 04:23:39 | pablogsal | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10616 |
| 2018-12-28 04:23:31 | pablogsal | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10615 |
| 2018-12-28 04:21:50 | pablogsal | create | |
