Issue35631
Created on 2019-01-01 07:35 by nnnnnn, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11396 | merged | nnnnnn, 2019-01-01 07:37 | |
| PR 11396 | merged | nnnnnn, 2019-01-01 07:37 | |
| PR 11396 | merged | nnnnnn, 2019-01-01 07:37 | |
| PR 11431 | merged | miss-islington, 2019-01-04 14:14 | |
| PR 11431 | merged | miss-islington, 2019-01-04 14:15 | |
| PR 11431 | merged | miss-islington, 2019-01-04 14:15 | |
| PR 11432 | closed | miss-islington, 2019-01-04 14:15 | |
| PR 11432 | closed | miss-islington, 2019-01-04 14:15 | |
| PR 11432 | closed | miss-islington, 2019-01-04 14:15 | |
| Messages (5) | |||
|---|---|---|---|
| msg332842 - (view) | Author: (nnnnnn) * | Date: 2019-01-01 07:35 | |
The typing docs for List includes a note to use generic collection types, but lists AbstractSet and Mapping which aren't generally replacements for a List. It would be better to remove those types from the List note and add corresponding ones to Dict and Set which are currently lacking it. Additionally, some examples in the typing docs are in violation of the above stated preference, using Lists and Dicts as parameters. |
|||
| msg332843 - (view) | Author: (nnnnnn) * | Date: 2019-01-01 07:58 | |
(s/generic collection types/abstract collection types/ in the initial message) |
|||
| msg332979 - (view) | Author: Ivan Levkivskyi (levkivskyi) *  |
Date: 2019-01-04 14:14 | |
New changeset 31ec52a9afedd77e36a3ddc31c4c45664b8ac410 by Ivan Levkivskyi (Ville Skyttä) in branch 'master': bpo-35631: Improve typing docs wrt abstract/concrete collection types (GH-11396) https://github.com/python/cpython/commit/31ec52a9afedd77e36a3ddc31c4c45664b8ac410 |
|||
| msg332980 - (view) | Author: miss-islington (miss-islington) | Date: 2019-01-04 14:20 | |
New changeset 902196d867a34cc154fa9c861c883e69232251c6 by Miss Islington (bot) in branch '3.7': bpo-35631: Improve typing docs wrt abstract/concrete collection types (GH-11396) https://github.com/python/cpython/commit/902196d867a34cc154fa9c861c883e69232251c6 |
|||
| msg332981 - (view) | Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2019-01-04 14:26 | |
I think this can be closed now. Whether to merge doc-fix backport to now security-only 3.6 branch is up to Ned. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:09 | admin | set | github: 79812 |
| 2019-01-04 14:26:42 | levkivskyi | set | status: open -> closed messages: + msg332981 keywords:
patch, patch, patch |
| 2019-01-04 14:20:21 | miss-islington | set | nosy:
+ miss-islington messages: + msg332980 |
| 2019-01-04 14:15:31 | miss-islington | set | pull_requests: + pull_request10855 |
| 2019-01-04 14:15:25 | miss-islington | set | pull_requests: + pull_request10858 |
| 2019-01-04 14:15:18 | miss-islington | set | pull_requests: + pull_request10857 |
| 2019-01-04 14:15:11 | miss-islington | set | pull_requests: + pull_request10856 |
| 2019-01-04 14:15:05 | miss-islington | set | pull_requests: + pull_request10854 |
| 2019-01-04 14:14:58 | miss-islington | set | pull_requests: + pull_request10853 |
| 2019-01-04 14:14:36 | levkivskyi | set | messages: + msg332979 |
| 2019-01-02 14:01:08 | levkivskyi | set | keywords:
patch, patch, patch nosy: + levkivskyi |
| 2019-01-01 07:58:02 | nnnnnn | set | messages: + msg332843 |
| 2019-01-01 07:37:47 | nnnnnn | set | keywords:
+ patch stage: patch review pull_requests: + pull_request10776 |
| 2019-01-01 07:37:42 | nnnnnn | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10775 |
| 2019-01-01 07:37:37 | nnnnnn | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10774 |
| 2019-01-01 07:35:43 | nnnnnn | create | |