Issue35982
Created on 2019-02-13 09:41 by nanjekyejoannah, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11838 | closed | matrixise, 2019-02-13 10:49 | |
| Messages (11) | |||
|---|---|---|---|
| msg335395 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) *  |
Date: 2019-02-13 09:41 | |
In a discussion to fix https://bugs.python.org/issue35951, @giampaolo.rodola pointed out that there are no tests for os.renames() I have opened this issue to track this. |
|||
| msg335399 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-02-13 09:58 | |
good catch |
|||
| msg335400 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2019-02-13 10:02 | |
I am working on this. |
|||
| msg335401 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-02-13 10:12 | |
ok, I was working on this issue. |
|||
| msg335402 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-02-13 10:17 | |
You can check this branch, but I have not created the PR because you were working on this issue. https://github.com/matrixise/cpython/commit/3f23deceef423b038273d28080d4aaee664b6bc9 |
|||
| msg335403 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-02-13 10:52 | |
ok, I have created a PR, you can comment it and we can work together on this PR. Have a nice day, Stéphane |
|||
| msg335407 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-02-13 11:09 | |
Hi Giampaolo, I added you to this issue, about the tests, I have created a very simple test but I would like to know your advice. Thank you, |
|||
| msg335413 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2019-02-13 11:20 | |
If you have created a PR, that is fine. Am not able to look now though may be later. |
|||
| msg335448 - (view) | Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2019-02-13 15:25 | |
Assigning this to me. FWIW I created a post on python-dev in order to add a test.support.rmpath() utility function and hopefully cover other os.* functions which may also be untested or not properly tested: https://mail.python.org/pipermail/python-dev/2019-February/156267.html |
|||
| msg338723 - (view) | Author: Stéphane Wirtel (matrixise) * |
Date: 2019-03-24 06:16 | |
I have closed my PR, feel free to submit an other PR. Have a nice day. |
|||
| msg349113 - (view) | Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2019-08-06 16:48 | |
@giampaolo, are you still working on these tests? If not can someone else pick this up? |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:11 | admin | set | github: 80163 |
| 2019-08-06 16:48:16 | nanjekyejoannah | set | stage: needs patch messages: + msg349113 components: + Tests versions: + Python 3.9 |
| 2019-03-24 06:16:38 | matrixise | set | messages: + msg338723 |
| 2019-02-13 15:25:27 | giampaolo.rodola | set | assignee: giampaolo.rodola messages: + msg335448 |
| 2019-02-13 11:20:46 | nanjekyejoannah | set | messages: + msg335413 |
| 2019-02-13 11:09:44 | matrixise | set | nosy:
+ giampaolo.rodola messages: + msg335407 |
| 2019-02-13 10:52:46 | matrixise | set | messages:
+ msg335403 stage: patch review -> (no value) |
| 2019-02-13 10:49:35 | matrixise | set | keywords:
+ patch stage: patch review pull_requests: + pull_request11868 |
| 2019-02-13 10:17:11 | matrixise | set | messages: + msg335402 |
| 2019-02-13 10:12:38 | matrixise | set | messages: + msg335401 |
| 2019-02-13 10:02:53 | nanjekyejoannah | set | messages: + msg335400 |
| 2019-02-13 09:58:49 | matrixise | set | nosy:
+ matrixise messages: + msg335399 |
| 2019-02-13 09:41:27 | nanjekyejoannah | create | |