Issue36555
Created on 2019-04-08 10:50 by crusaderky, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Messages (3) | |||
|---|---|---|---|
| msg339610 - (view) | Author: Guido Imperiale (crusaderky) * | Date: 2019-04-08 10:50 | |
An exceedingly common pattern in many Python libraries is for a function to accept either a string or a list of strings, and change the function output accordingly.
This however does not play nice with @typing.overload, as a str variable is also an Iterable[str] that yields individual characters; a bytes variable is also an Iterable[bytes].
The example below confuses tools like mypy:
@overload
def f(x: str) -> int
...
@overload
def f(x: Iterable[str]) -> List[int]
...
def f(x):
if isinstance(x, str):
return len(x)
return [len(i) for i in x]
mypy output:
error: Overloaded function signatures 1 and 2 overlap with incompatible return types
The proposed solution is to modify PEP484 to specify that, in case of ambiguity, whatever overloaded typing is defined first wins. This would be coherent with the behaviour of @functools.singledispatch.
|
|||
| msg339615 - (view) | Author: Ivan Levkivskyi (levkivskyi) * ![]() |
Date: 2019-04-08 11:22 | |
Mypy already takes first overload for ambiguous arguments. This example is however genuinely unsafe from the static typing point of view. Please read the docs https://mypy.readthedocs.io/en/latest/more_types.html#type-checking-the-variants |
|||
| msg339889 - (view) | Author: Guido van Rossum (gvanrossum) * ![]() |
Date: 2019-04-10 20:27 | |
> Mypy already takes first overload for ambiguous arguments. This is true, but it requires that the return types match (covariantly, IIUC) for the overlapping types. So you can have @overload def foo(x: int) -> int: ... @overload def foo(x: float) -> float: ... But you can't have @overload def foo(x: int) -> str: ... @overload def foo(x: float) -> float: ... (and the docs explain why -- search for "unsafe_func"). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:13 | admin | set | github: 80736 |
| 2019-04-10 20:27:59 | gvanrossum | set | messages: + msg339889 |
| 2019-04-08 11:22:41 | levkivskyi | set | status: open -> closed resolution: not a bug messages: + msg339615 stage: resolved |
| 2019-04-08 11:10:16 | xtreak | set | nosy:
+ gvanrossum, levkivskyi |
| 2019-04-08 10:50:12 | crusaderky | create | |
