Issue36689
Created on 2019-04-21 09:09 by lazka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 14045 | merged | makdon, 2019-06-13 07:30 | |
| Messages (7) | |||
|---|---|---|---|
| msg340604 - (view) | Author: Christoph Reiter (lazka) * | Date: 2019-04-21 09:09 | |
Since I just got bit by this despite reading the docs: https://docs.python.org/3.8/library/os.path.html#os.path.commonpath It lists various error cases where ValueError is raised but is missing the case where absolute paths on Windows are on different drives and I forgot to handle that: File "C:/building/msys64/mingw64/lib/python3.7\ntpath.py", line 631, in commonpath raise ValueError("Paths don't have the same drive") ValueError: Paths don't have the same drive |
|||
| msg340756 - (view) | Author: Patrick Artman (pjartman) | Date: 2019-04-24 02:54 | |
If this isn't taken I'd be happy to give it a go as my first contribution |
|||
| msg342273 - (view) | Author: Windson Yang (Windson Yang) * | Date: 2019-05-13 00:25 | |
An easy fix would be "Raise ValueError if paths contain (note: use contain instead of contains) both absolute and relative pathnames or the path are on the different drives." |
|||
| msg345410 - (view) | Author: Guido van Rossum (gvanrossum) *  |
Date: 2019-06-12 21:19 | |
Flagging as Windows issue. |
|||
| msg345468 - (view) | Author: makdon (makdon) * | Date: 2019-06-13 07:30 | |
I create a PR according Windson Yang's suggestion. |
|||
| msg346921 - (view) | Author: Avinash Sajjanshetty (avi) * | Date: 2019-06-30 08:09 | |
status of issue should be closed? cos the related PR is already merged |
|||
| msg346922 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2019-06-30 08:34 | |
Yes, sure |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:14 | admin | set | github: 80870 |
| 2019-06-30 08:34:42 | asvetlov | set | status: open -> closed nosy:
+ asvetlov resolution: fixed |
| 2019-06-30 08:09:11 | avi | set | nosy:
+ avi messages: + msg346921 |
| 2019-06-13 07:30:13 | makdon | set | nosy:
+ makdon messages: + msg345468 pull_requests: + pull_request13908 keywords:
+ patch |
| 2019-06-12 22:05:08 | gvanrossum | set | nosy:
- gvanrossum |
| 2019-06-12 21:19:24 | gvanrossum | set | nosy:
+ paul.moore, tim.golden, gvanrossum, zach.ware, steve.dower messages: + msg345410 components: + Windows |
| 2019-05-13 00:25:44 | Windson Yang | set | nosy:
+ Windson Yang messages: + msg342273 |
| 2019-04-24 02:54:29 | pjartman | set | nosy:
+ pjartman messages: + msg340756 |
| 2019-04-21 10:16:07 | serhiy.storchaka | set | keywords:
+ easy stage: needs patch versions: + Python 3.7 |
| 2019-04-21 09:09:18 | lazka | create | |